From: Oleg Nesterov <oleg@redhat.com>
To: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Anton Arapov <anton@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Rabin Vincent <rabin@rab.in>,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] uprobes: Kill arch_uprobe_enable/disable_step() hooks
Date: Sun, 28 Oct 2012 18:39:36 +0100 [thread overview]
Message-ID: <20121028173936.GA14659@redhat.com> (raw)
In-Reply-To: <20121028173900.GA14621@redhat.com>
Kill arch_uprobe_enable/disable_step() hooks, they do nothing and
nobody needs them.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
include/linux/uprobes.h | 2 --
kernel/events/uprobes.c | 10 ----------
2 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
index 2459457..2615c4d 100644
--- a/include/linux/uprobes.h
+++ b/include/linux/uprobes.h
@@ -101,8 +101,6 @@ extern void uprobe_dup_mmap(struct mm_struct *oldmm, struct mm_struct *newmm);
extern void uprobe_free_utask(struct task_struct *t);
extern void uprobe_copy_process(struct task_struct *t);
extern unsigned long __weak uprobe_get_swbp_addr(struct pt_regs *regs);
-extern void __weak arch_uprobe_enable_step(struct arch_uprobe *arch);
-extern void __weak arch_uprobe_disable_step(struct arch_uprobe *arch);
extern int uprobe_post_sstep_notifier(struct pt_regs *regs);
extern int uprobe_pre_sstep_notifier(struct pt_regs *regs);
extern void uprobe_notify_resume(struct pt_regs *regs);
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 916391e..02d7c5f 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -1430,14 +1430,6 @@ static struct uprobe *find_active_uprobe(unsigned long bp_vaddr, int *is_swbp)
return uprobe;
}
-void __weak arch_uprobe_enable_step(struct arch_uprobe *arch)
-{
-}
-
-void __weak arch_uprobe_disable_step(struct arch_uprobe *arch)
-{
-}
-
/*
* Run handler and ask thread to singlestep.
* Ensure all non-fatal signals cannot interrupt thread while it singlesteps.
@@ -1491,7 +1483,6 @@ static void handle_swbp(struct pt_regs *regs)
goto out;
if (!pre_ssout(uprobe, regs, bp_vaddr)) {
- arch_uprobe_enable_step(&uprobe->arch);
utask->active_uprobe = uprobe;
utask->state = UTASK_SSTEP;
return;
@@ -1523,7 +1514,6 @@ static void handle_singlestep(struct uprobe_task *utask, struct pt_regs *regs)
else
WARN_ON_ONCE(1);
- arch_uprobe_disable_step(&uprobe->arch);
put_uprobe(uprobe);
utask->active_uprobe = NULL;
utask->state = UTASK_RUNNING;
--
1.5.5.1
next prev parent reply other threads:[~2012-10-28 17:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 17:39 [PATCH 0/4] uprobes: Kill arch_uprobe_enable/disable_step() hooks Oleg Nesterov
2012-10-28 17:39 ` [PATCH 1/4] uprobes/powerpc: Don't clear TIF_UPROBE in do_notify_resume() Oleg Nesterov
2012-10-29 5:27 ` Ananth N Mavinakayanahalli
2012-10-29 7:02 ` Srikar Dronamraju
2012-10-29 12:43 ` Oleg Nesterov
2012-10-29 13:28 ` Ananth N Mavinakayanahalli
2012-11-02 5:02 ` Srikar Dronamraju
2012-10-28 17:39 ` [PATCH 2/4] uprobes/powerpc: Do not use arch_uprobe_*_step() helpers Oleg Nesterov
2012-10-29 5:33 ` Ananth N Mavinakayanahalli
2012-11-02 5:03 ` Srikar Dronamraju
2012-10-28 17:39 ` [PATCH 3/4] uprobes/x86: Cleanup the single-stepping code Oleg Nesterov
2012-11-02 12:51 ` Srikar Dronamraju
2012-10-28 17:39 ` Oleg Nesterov [this message]
2012-11-02 12:50 ` [PATCH 4/4] uprobes: Kill arch_uprobe_enable/disable_step() hooks Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121028173936.GA14659@redhat.com \
--to=oleg@redhat.com \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rabin@rab.in \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).