From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758347Ab2J2JDy (ORCPT ); Mon, 29 Oct 2012 05:03:54 -0400 Received: from mail.us.es ([193.147.175.20]:59723 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756686Ab2J2JDv (ORCPT ); Mon, 29 Oct 2012 05:03:51 -0400 X-Qmail-Scanner-Diagnostics: from 127.0.0.1 by antivirus2 (envelope-from , uid 501) with qmail-scanner-2.10 (clamdscan: 0.97.6/15516. spamassassin: 3.3.2. Clear:RC:1(127.0.0.1):SA:0(-100.6/7.5):. Processed in 1.830564 secs); 29 Oct 2012 09:03:49 -0000 X-Envelope-From: pneira@us.es Date: Mon, 29 Oct 2012 10:03:47 +0100 From: Pablo Neira Ayuso To: Fengguang Wu Cc: Patrick McHardy , netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: use PTR_RET Message-ID: <20121029090347.GA10521@1984> References: <20121029004044.GA12982@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121029004044.GA12982@localhost> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 29, 2012 at 08:40:44AM +0800, Fengguang Wu wrote: > Use PTR_RET rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: coccinelle/api/ptr_ret.cocci Applied, thanks. I have collapsed this patch and the one for ipv6/iptable_nat.c. They are pretty small and description is the same.