From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752819Ab2J2JN1 (ORCPT ); Mon, 29 Oct 2012 05:13:27 -0400 Received: from mga09.intel.com ([134.134.136.24]:20499 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750968Ab2J2JN0 (ORCPT ); Mon, 29 Oct 2012 05:13:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,670,1344236400"; d="scan'208";a="212384585" Date: Mon, 29 Oct 2012 17:13:23 +0800 From: Fengguang Wu To: Pablo Neira Ayuso Cc: Patrick McHardy , netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: use PTR_RET Message-ID: <20121029091323.GA25000@localhost> References: <20121029004044.GA12982@localhost> <20121029090347.GA10521@1984> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121029090347.GA10521@1984> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 29, 2012 at 10:03:47AM +0100, Pablo Neira Ayuso wrote: > On Mon, Oct 29, 2012 at 08:40:44AM +0800, Fengguang Wu wrote: > > Use PTR_RET rather than if(IS_ERR(...)) + PTR_ERR > > > > Generated by: coccinelle/api/ptr_ret.cocci > > Applied, thanks. > > I have collapsed this patch and the one for ipv6/iptable_nat.c. They > are pretty small and description is the same. That would be good, thanks! Thanks, Fengguang