From: Greg KH <gregkh@linuxfoundation.org>
To: George Zhang <georgezhang@vmware.com>
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, pv-drivers@vmware.com
Subject: Re: [PATCH 12/12] VMCI: Some header and config files.
Date: Mon, 29 Oct 2012 19:32:55 -0700 [thread overview]
Message-ID: <20121030023255.GJ1920@kroah.com> (raw)
In-Reply-To: <20121030010533.17788.79417.stgit@promb-2n-dhcp175.eng.vmware.com>
On Mon, Oct 29, 2012 at 06:05:38PM -0700, George Zhang wrote:
> --- /dev/null
> +++ b/drivers/misc/vmw_vmci/Makefile
> @@ -0,0 +1,43 @@
> +################################################################################
> +#
> +# Linux driver for VMware's VMCI device.
> +#
> +# Copyright (C) 2007-2012, VMware, Inc. All Rights Reserved.
> +#
> +# This program is free software; you can redistribute it and/or modify it
> +# under the terms of the GNU General Public License as published by the
> +# Free Software Foundation; version 2 of the License and no later version.
> +#
> +# This program is distributed in the hope that it will be useful, but
> +# WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
> +# NON INFRINGEMENT. See the GNU General Public License for more
> +# details.
> +#
> +# Maintained by: Andrew Stiegmann <pv-drivers@vmware.com>
> +#
> +################################################################################
That's a big boiler-plate for a makefile :)
Wait, what's Andrew's name doing here, and yet it isn't on any of the
signed-off-by: or From: lines of the driver? Surely you aren't the only
contributor here?
> +#
> +# Makefile for the VMware VMCI
> +#
That's the only needed comment for this file, if even that.
> +
> +obj-$(CONFIG_VMWARE_VMCI) += vmw_vmci.o
> +
> +vmw_vmci-y += vmci_context.o
> +vmw_vmci-y += vmci_datagram.o
> +vmw_vmci-y += vmci_doorbell.o
> +vmw_vmci-y += vmci_driver.o
> +vmw_vmci-y += vmci_event.o
> +vmw_vmci-y += vmci_guest.o
> +vmw_vmci-y += vmci_handle_array.o
> +vmw_vmci-y += vmci_host.o
> +vmw_vmci-y += vmci_queue_pair.o
> +vmw_vmci-y += vmci_resource.o
> +vmw_vmci-y += vmci_route.o
You can do this cleaner with multiple .o objects on the same line...
> +vmci:
> + $(MAKE) -C ../../.. SUBDIRS=$$PWD CONFIG_VMWARE_VMCI=m modules
> +
> +clean:
> + $(MAKE) -C ../../.. SUBDIRS=$$PWD CONFIG_VMWARE_VMCI=m clean
What are these two last targets for? I'm guessing this is from when you
ported it from a stand-along module? Please remove them.
greg k-h
next prev parent reply other threads:[~2012-10-30 2:32 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 1:03 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-10-30 1:03 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-10-30 2:07 ` Greg KH
2012-10-30 2:10 ` Greg KH
2012-10-30 4:01 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 15:46 ` Greg KH
2012-10-30 15:56 ` Dmitry Torokhov
2012-10-30 1:03 ` [PATCH 02/12] VMCI: datagram implementation George Zhang
2012-10-30 1:04 ` [PATCH 03/12] VMCI: doorbell implementation George Zhang
2012-10-30 1:04 ` [PATCH 04/12] VMCI: device driver implementaton George Zhang
2012-10-30 2:21 ` Greg KH
2012-10-30 2:23 ` Greg KH
2012-10-30 4:15 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 15:49 ` Greg KH
2012-10-30 1:04 ` [PATCH 05/12] VMCI: event handling implementation George Zhang
2012-10-30 2:24 ` Greg KH
2012-10-30 4:58 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 15:50 ` Greg KH
2012-10-30 2:26 ` Greg KH
2012-10-30 5:01 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 15:50 ` Greg KH
2012-10-30 15:59 ` Dmitry Torokhov
2012-10-30 1:04 ` [PATCH 06/12] VMCI: handle array implementation George Zhang
2012-10-30 1:04 ` [PATCH 07/12] VMCI: queue pairs implementation George Zhang
2012-10-30 1:04 ` [PATCH 08/12] VMCI: resource object implementation George Zhang
2012-10-30 2:29 ` Greg KH
2012-10-30 5:20 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 15:51 ` Greg KH
2012-10-30 16:11 ` Dmitry Torokhov
2012-10-30 2:29 ` Greg KH
2012-10-30 5:21 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 1:05 ` [PATCH 09/12] VMCI: routing implementation George Zhang
2012-10-30 1:05 ` [PATCH 10/12] VMCI: guest side driver implementation George Zhang
2012-10-30 1:05 ` [PATCH 11/12] VMCI: host " George Zhang
2012-10-30 1:05 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2012-10-30 2:32 ` Greg KH [this message]
2012-10-30 5:22 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 2:38 ` Greg KH
2012-10-30 2:19 ` [PATCH 00/12] VMCI for Linux upstreaming Greg KH
2012-10-30 4:07 ` [Pv-drivers] " Dmitry Torokhov
2012-10-30 15:48 ` Greg KH
2012-10-30 16:18 ` Dmitry Torokhov
2012-10-30 16:27 ` Greg KH
2012-10-30 19:43 ` Dmitry Torokhov
2012-10-30 19:59 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2012-11-01 17:28 George Zhang
2012-11-01 17:30 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2012-11-07 18:40 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-07 18:43 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2012-11-16 0:01 ` Greg KH
2012-11-27 0:03 ` Greg KH
2012-11-27 0:23 ` Dmitry Torokhov
2012-11-27 0:32 ` Greg KH
2012-11-30 16:47 ` Andy King
2012-11-30 17:09 ` Greg KH
2012-11-21 20:31 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-21 20:36 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2013-01-08 23:52 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2013-01-08 23:55 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030023255.GJ1920@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=georgezhang@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).