From: Feng Tang <feng.tang@intel.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>, Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 5/8] perf ui/browser: Integrate script browser into main hists browser
Date: Wed, 31 Oct 2012 00:05:53 +0800 [thread overview]
Message-ID: <20121030160553.GA21738@feng-snb> (raw)
In-Reply-To: <20121029145423.GF6754@infradead.org>
On Mon, Oct 29, 2012 at 12:54:23PM -0200, Arnaldo Carvalho de Melo wrote:
> Em Tue, Oct 30, 2012 at 11:56:06AM +0800, Feng Tang escreveu:
> > Integrate the script browser into "perf report" framework, users can
> > use function key 'r' or the drop down menu to list all perf scripts
> > and select one of them, just like they did for the annotation.
> >
> > Signed-off-by: Feng Tang <feng.tang@intel.com>
>
> I noticed this comment on another patch:
>
> --------------------------
> This initial version only enables it for 'perf report', by checking
> the "timer" parameter of perf_evsel__hists_browser() equals NULL.
> --------------------------
>
> Yeah, one can say that if a timer is provided, we can say its 'top' and
> not 'report', at least as things stand now.
>
> So please add a 'is_top(void *timer)' so that we know the intent more
> clearly and use it to avoid showing the 'r' key when in 'top' mode, ok?
Will do and thanks for the catch. I once thought about hiding script option
for 'top' mode, but forgot to follow it on.
Thanks,
Feng
next prev parent reply other threads:[~2012-10-29 16:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 3:56 [PATCH v5 0/8] perf tools: Add script browser and runtime data file switch Feng Tang
2012-10-30 3:56 ` [PATCH v5 1/8] perf tool: Add a global variable "const char *input_name" Feng Tang
2012-10-30 12:05 ` [tip:perf/core] perf tools: Add a global variable " const " tip-bot for Feng Tang
2012-10-30 3:56 ` [PATCH v5 2/8] perf script: Add more filter to find_scripts() Feng Tang
2012-10-30 12:06 ` [tip:perf/core] " tip-bot for Feng Tang
2012-10-30 3:56 ` [PATCH v5 3/8] perf ui/browser: Add a browser for perf script Feng Tang
2012-10-30 12:07 ` [tip:perf/core] perf scripts browser: " tip-bot for Feng Tang
2012-10-30 3:56 ` [PATCH v5 4/8] perf ui/browser: Integrate script browser into annotation browser Feng Tang
2012-10-30 12:08 ` [tip:perf/core] perf annotate browser: " tip-bot for Feng Tang
2012-10-30 3:56 ` [PATCH v5 5/8] perf ui/browser: Integrate script browser into main hists browser Feng Tang
2012-10-29 14:54 ` Arnaldo Carvalho de Melo
2012-10-30 16:05 ` Feng Tang [this message]
2012-10-30 12:09 ` [tip:perf/core] perf hists browser: " tip-bot for Feng Tang
2012-10-30 3:56 ` [PATCH v5 6/8] perf header: Add is_perf_magic() func Feng Tang
2012-10-30 12:10 ` [tip:perf/core] " tip-bot for Feng Tang
2012-10-30 3:56 ` [PATCH v5 7/8] perf hists browser: Add option for runtime switching perf data file Feng Tang
2012-10-29 14:06 ` Arnaldo Carvalho de Melo
2012-10-30 16:01 ` Feng Tang
2012-10-30 3:56 ` [PATCH v5 8/8] perf report: Enable the runtime switching of " Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030160553.GA21738@feng-snb \
--to=feng.tang@intel.com \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox