Re: [PATCH v2 03/10] compiler-gcc{3,4}.h: Use GCC_VERSION macro

Josh Triplett
2012-10-09T19:46:06Z

On Tue, Oct 09, 2012 at 11:41:58AM -0700, Andrew Morton wrote:
> On Sun, 07 Oct 2012 13:27:58 -0500
> Daniel Santos <danielfsantos@att.net> wrote:
>
> > We'll have to ask Andrew. Maybe so he can test on those versions of gcc?
> >
> > commit d3ffe64a1dbcfe18b57f90f7c01c40c93d0a8b92
> > Author: Andrew Morton <akpm@linux-foundation.org>
> > Date: Fri Sep 28 00:02:42 2012 +0000
> >
> > a
> >
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> >
> > diff --git a/include/linux/compiler-gcc4.h b/include/linux/compiler-gcc4.h
> > index 934bc34..997fd8a 100644
> > --- a/include/linux/compiler-gcc4.h
> > +++ b/include/linux/compiler-gcc4.h
> > @@ -5,7 +5,7 @@
> > /* GCC 4.1.[01] miscompiles __weak */
> > #ifdef __KERNEL__
> > # if __GNUC_MINOR__ == 1 && __GNUC_PATCHLEVEL__ <= 1
> > -# error Your version of gcc miscompiles the __weak directive
> > +//# error Your version of gcc miscompiles the __weak directive
>
> hm, yeah, sorry, I use various old crufty cross-compilers.

Ah, for build testing where you don't actually care if the resulting
kernel runs?

- Josh Triplett