Re: [Bulk] Re: [PATCH 4/10] compiler-gcc{3,4}.h: Use GCC_VERSION macro

David Rientjes
2012-10-03T06:41:00Z

On Fri, 28 Sep 2012, Josh Triplett wrote:

> GCC 4.1.0 and 4.1.1 miscompiling __weak has nothing to do with
> __compiletime_object_size; why should *this* version check exclude those
> versions?
>

Agreed, we shouldn't be relying on any #error directives to fail the build
and then try to factor those version numbers out of other directives; if
the #error directive were ever to be removed (or commented out, like in
this case), nobody would make the other directives inclusive of that
now-allowed version where things like __compiletime_object_size() are
valid.

After __compiletime_object_size() is compiled for GCC_VERSION >= 40100,
then:

Acked-by: David Rientjes <rientjes@google.com>