Re: [PATCH 4/10] compiler-gcc{3,4}.h: Use GCC_VERSION macro

Josh Triplett
2012-09-29T00:20:39Z

On Fri, Sep 28, 2012 at 06:20:05PM -0500, Daniel Santos wrote:
> --- a/include/linux/compiler-gcc4.h
> +++ b/include/linux/compiler-gcc4.h
> @@ -13,11 +13,11 @@
> #define __must_check __attribute__((warn_unused_result))
> #define __compiler_offsetof(a,b) __builtin_offsetof(a,b)
>
> -#if __GNUC_MINOR__ > 0
> +#if GCC_VERSION >= 40102
> # define __compiletime_object_size(obj) __builtin_object_size(obj, 0)
> #endif

You've changed the semantics of this one; if literally translated, this
should have become #if GCC_VERSION >= 40100. If you intended to change
that, could you please document why? And in any case, could you make
that semantic change in a separate commit from the switch to
GCC_VERSION?

- Josh Triplett