From: Anton Vorontsov <cbouatmailru@gmail.com>
To: yongd <yongd@marvell.com>
Cc: Chris Ball <cjb@laptop.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Shawn Guo <shawn.guo@linaro.org>,
Wolfram Sang <w.sang@pengutronix.de>,
Daniel Drake <dsd@laptop.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Wilson Callan <wilson.callan@savantsystems.com>,
Ben Dooks <ben-linux@fluff.org>,
zhangfei.gao@marvell.com, kevin.liu@marvell.com,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 0/3] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host
Date: Tue, 30 Oct 2012 16:11:25 -0700 [thread overview]
Message-ID: <20121030231124.GA2902@lizard> (raw)
In-Reply-To: <1351589403-26398-1-git-send-email-yongd@marvell.com>
On Tue, Oct 30, 2012 at 05:30:00PM +0800, yongd wrote:
> Sorry for my so late. And eventually these updated patches are here for your
> review. Thanks in advance.
> For patch 1, add SDHCI_QUIRK_BROKEN_CARD_DETECTION setting for ESDHC_CD_GPIO type,
> or the host controller detection interrupts will be redundantly enabled. And its
> comment is correspondingly updated.
> For patch 2, broaden SDHCI_QUIRK_BROKEN_CARD_DETECTION setting for all detection
> types except S3C_SDHCI_CD_INTERNAL. Then also update the comment.
> For patch 3, no update.
They all look OK, but note that I did not check drivers' logic, so I hope
you carefully reviewed all the drivers yourself. :)
Unfortunately, you decided to go the dangerous way, instead of taking my
100%-safe approach (i.e.
http://www.mail-archive.com/linux-mmc@vger.kernel.org/msg16555.html ),
which, to me, still makes more sense (of course :).
Anyways, I'm not opposed either, so hopefully it works:
Reviewed-by: Anton Vorontsov <cbouatmailru@gmail.com>
Thanks!
Anton.
next prev parent reply other threads:[~2012-10-30 23:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 9:30 [PATCH V2 0/3] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host yongd
2012-10-30 9:30 ` [PATCH V2 1/3] mmc: esdhc: enable polling to detect card by itself yongd
2012-10-31 15:20 ` Shawn Guo
2012-11-02 12:37 ` yongd
2012-11-05 1:54 ` Shawn Guo
2012-11-05 3:34 ` yongd
2012-11-05 12:48 ` Shawn Guo
2012-11-06 8:49 ` yongd
2012-11-06 12:52 ` Shawn Guo
2012-11-08 2:46 ` yongd
2012-10-30 9:30 ` [PATCH V2 2/3] mmc: sdhci-s3c: " yongd
2012-10-30 23:11 ` Anton Vorontsov [this message]
2012-10-31 10:07 ` [PATCH V2 0/3] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host yongd
2012-10-31 10:14 ` yongd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030231124.GA2902@lizard \
--to=cbouatmailru@gmail.com \
--cc=ben-linux@fluff.org \
--cc=cjb@laptop.org \
--cc=dsd@laptop.org \
--cc=kevin.liu@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=w.sang@pengutronix.de \
--cc=wilson.callan@savantsystems.com \
--cc=yongd@marvell.com \
--cc=zhangfei.gao@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).