Re: [PATCH 4/4] cpufreq, highbank: add support for highbank cpufreq

Shawn Guo
2013-01-26T14:40:17Z

Mark,

On Fri, Jan 25, 2013 at 01:46:45PM -0600, Mark Langsdorf wrote:
> +static int hb_cpufreq_driver_init(void)
> +{
> + struct device *cpu_dev;
> + struct clk *cpu_clk;
> + struct device_node *np;
> + int ret;
> +
> + for_each_child_of_node(of_find_node_by_path("/cpus"), np)
> + if (of_get_property(np, "operating-points", NULL))
> + break;
> +
> + if (!np) {
> + pr_err("failed to find highbank cpufreq node\n");
> + return -ENOENT;
> + }
> +
...
> +out_put_node:
> + of_node_put(np);
> + return ret;
> +}
> +module_init(hb_cpufreq_driver_init);

As we are moving to multiplatform build, this init function will run
on all other platforms built together with highbank. We should
probably eliminate that effect. cpufreq-cpu0 driver is facing the
same problem, and I just sent a patch "cpufreq: instantiate cpufreq-cpu0
as a platform_driver" to address that.

Shawn