From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423181Ab2JaQXh (ORCPT ); Wed, 31 Oct 2012 12:23:37 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:56663 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935728Ab2JaQXf (ORCPT ); Wed, 31 Oct 2012 12:23:35 -0400 Date: Wed, 31 Oct 2012 09:23:30 -0700 From: Tejun Heo To: Aristeu Rozanski Cc: linux-kernel@vger.kernel.org, Andrew Morton , Li Zefan , James Morris , Pavel Emelyanov , Serge Hallyn , Jiri Slaby , cgroups@vger.kernel.org Subject: Re: [PATCH] device_cgroup: fix unchecked cgroup parent usage Message-ID: <20121031162330.GA2945@htj.dyndns.org> References: <20121031160430.GD14789@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121031160430.GD14789@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 31, 2012 at 12:04:30PM -0400, Aristeu Rozanski wrote: > In 4cef7299b4786879a3e113e84084a72b24590c5b the cgroup parent usage is > unchecked. root will not have a parent and trying to use > device.{allow,deny} will cause problems. For some reason my stressing > scripts didn't test the root directory so I didn't catch it on my > regular tests. > > Andrew, Tejun, this patch needs to make Linus tree ASAP or a revert for > 4cef7299b4786879a3e113e84084a72b24590c5b. Acked-by: Tejun Heo Andrew, can you please pick this one up? Thanks. -- tejun