From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: David Rientjes <rientjes@google.com>, JBeulich@suse.com
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, xen-devel@lists.xensource.com,
linux-kernel@vger.kernel.org
Subject: Re: [patch] x86, xen: fix build dependency when USB_SUPPORT is not enabled
Date: Thu, 1 Nov 2012 08:49:13 -0400 [thread overview]
Message-ID: <20121101124912.GA10743@localhost.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.00.1210312239120.31758@chino.kir.corp.google.com>
On Wed, Oct 31, 2012 at 10:42:30PM -0700, David Rientjes wrote:
> CONFIG_XEN_DOM0 must depend on CONFIG_USB_SUPPORT, otherwise there is no
> definition of xen_dbgp_reset_prep() and xen_dbgp_external_startup()
> resulting in the following link error:
>
> drivers/built-in.o: In function `dbgp_reset_prep':
> (.text+0x1e03c5): undefined reference to `xen_dbgp_reset_prep'
> drivers/built-in.o: In function `dbgp_external_startup':
> (.text+0x1e0d55): undefined reference to `xen_dbgp_external_startup'
There is another patch that needs to be Acked and picked up by
Greg KH that fixes this.
Let me poke Jan Beulich to repost it with the appropiate Acks.
>
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
> arch/x86/xen/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
> --- a/arch/x86/xen/Kconfig
> +++ b/arch/x86/xen/Kconfig
> @@ -17,6 +17,7 @@ config XEN_DOM0
> def_bool y
> depends on XEN && PCI_XEN && SWIOTLB_XEN
> depends on X86_LOCAL_APIC && X86_IO_APIC && ACPI && PCI
> + depends on USB_SUPPORT
>
> # Dummy symbol since people have come to rely on the PRIVILEGED_GUEST
> # name in tools.
next prev parent reply other threads:[~2012-11-01 12:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 5:42 [patch] x86, xen: fix build dependency when USB_SUPPORT is not enabled David Rientjes
2012-11-01 12:49 ` Konrad Rzeszutek Wilk [this message]
2012-11-01 20:04 ` Jan Beulich
2012-11-01 22:05 ` Konrad Rzeszutek Wilk
2012-11-01 22:30 ` David Rientjes
2012-11-02 8:19 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101124912.GA10743@localhost.localdomain \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox