From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: alsa-devel@alsa-project.org,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] snd-es1968: remove pm_whitelist
Date: Thu, 1 Nov 2012 21:29:43 +0000 [thread overview]
Message-ID: <20121101212943.3f9fa50a@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <201211012155.54713.linux@rainbow-software.org>
On Thu, 1 Nov 2012 21:55:54 +0100
Ondrej Zary <linux@rainbow-software.org> wrote:
> pm_whitelist breaks suspend on all non-whitelisted cards for unknown purpose.
> Remove it. This fixes suspend on Terratec DMX and SF64-PCE2 cards.
Because lots of them broke laptops.
Why not just whitelist the ones you know works, given there are ones we
know doesn't so your patch is an instant regression guarantee ?
(and yes a blacklist might have been brighter but I don't know the
history and it's a bit late to fix)
next prev parent reply other threads:[~2012-11-01 21:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 20:55 [PATCH] snd-es1968: remove pm_whitelist Ondrej Zary
2012-11-01 21:29 ` Alan Cox [this message]
2012-11-01 21:58 ` Ondrej Zary
2012-11-04 8:29 ` [alsa-devel] " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101212943.3f9fa50a@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox