From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, arm@kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robherring2@gmail.com>
Subject: Re: [PATCH v2] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip
Date: Thu, 1 Nov 2012 23:20:10 +0100 [thread overview]
Message-ID: <20121101232010.78269291@skate> (raw)
In-Reply-To: <1351805329-19576-1-git-send-email-linus.walleij@linaro.org>
Linus,
On Thu, 1 Nov 2012 22:28:49 +0100, Linus Walleij wrote:
> +void fpga_handle_irq(struct pt_regs *regs);
This function does not need to be exposed in a public header: as
proposed for the bcm2835 and armada-370-xp IRQ controller drivers, the
driver should directly do handle_arch_irq = fpga_handle_irq, and
therefore there is no need for the machine desc structure to reference
fpga_handle_irq anymore.
> +void fpga_irq_init(void __iomem *, const char *, int, int, u32,
> + struct device_node *node);
> +int fpga_irq_of_init(struct device_node *node,
> + struct device_node *parent);
I don't think this function needs to be exported. Just move the
compatible string to drivers/irqchip/irqchip.c and instead of calling
of_irq_init(), call irqchip_init().
This will leave only the fpga_irq_init() function, which we could get
rid of once the non-DT support is removed.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-11-01 22:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 21:28 [PATCH v2] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip Linus Walleij
2012-11-01 22:20 ` Thomas Petazzoni [this message]
2012-11-02 12:15 ` Russell King - ARM Linux
2012-11-05 21:48 ` Rob Herring
2012-11-05 22:42 ` Arnd Bergmann
2012-11-05 23:14 ` Russell King - ARM Linux
2012-11-06 14:38 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101232010.78269291@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=arm@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robherring2@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox