Re: [PATCH] gpio-mcp23s08: Build I2C support even when CONFIG_I2C=m

Linus Walleij
2012-11-04T18:16:20Z

On Fri, Nov 2, 2012 at 1:09 AM, Daniel M. Weeks <dan@danweeks.net> wrote:

> The driver has both SPI and I2C pieces. The appropriate pieces are built based
> on whether SPI and/or I2C is/are enabled. However, it was only checking if I2C
> was built-in, never if it was built as a module. This patch checks for either
> since building both this driver and I2C as modules is possible.

Good catch!

> -#ifdef CONFIG_I2C
> +#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)

But don't do it like this, there are already helpers for exactly this.

Do:

#if IS_ENABLED(CONFIG_I2C)

Read include/linux/kconfig.h if in doubt...

Looking forward to v2!

Yours,
Linus Walleij