From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kumar amit mehta <gmate.amit@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
syahn@gctsemi.com, linux-kernel@vger.kernel.org,
Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Subject: Re: [PATCH] staging: gdm72xx: wm_ioctl.h: fixed a macro coding style
Date: Fri, 2 Nov 2012 11:14:52 +0300 [thread overview]
Message-ID: <20121102081452.GD32762@mwanda> (raw)
In-Reply-To: <20121102073630.GA30619@gmail.com>
On Fri, Nov 02, 2012 at 12:36:30AM -0700, Kumar amit mehta wrote:
> On Fri, Nov 02, 2012 at 09:55:55AM +0300, Dan Carpenter wrote:
> > On Thu, Nov 01, 2012 at 11:42:59PM -0700, Kumar Amit Mehta wrote:
> > > fix for macro coding style.
> > >
> >
> > No. The parenthesis are not needed. I assume this is a
> > checkpatch.pl warning?
> >
> > regards,
> > dan carpenter
> >
> Running checkpatch.pl on this file (wm_ioctl.h) returns error.
>
I think there are patches which fix checkpatch.pl for this but they
haven't been merged yet?
$ ./scripts/checkpatch.pl -f drivers/staging/gdm72xx/wm_ioctl.h
ERROR: Macros with complex values should be enclosed in parenthesis
#94: FILE: staging/gdm72xx/wm_ioctl.h:94:
+#define ifr_name ifr_ifrn.ifrn_name
total: 1 errors, 0 warnings, 97 lines checked
regards,
dan carpenter
next prev parent reply other threads:[~2012-11-02 8:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 6:42 [PATCH] staging: gdm72xx: wm_ioctl.h: fixed a macro coding style Kumar Amit Mehta
2012-11-02 6:55 ` Dan Carpenter
2012-11-02 7:36 ` Kumar amit mehta
2012-11-02 8:14 ` Dan Carpenter [this message]
2012-11-02 8:50 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102081452.GD32762@mwanda \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gmate.amit@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syahn@gctsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox