From: Vivek Goyal <vgoyal@redhat.com>
To: Robin Dong <robin.k.dong@gmail.com>
Cc: linux-kernel@vger.kernel.org, Robin Dong <sanbai@taobao.com>
Subject: Re: [PATCH 1/2 v5] block/throttle: remove redundant type transition
Date: Fri, 2 Nov 2012 16:22:32 -0400 [thread overview]
Message-ID: <20121102202232.GU3300@redhat.com> (raw)
In-Reply-To: <1351848697-26087-1-git-send-email-robin.k.dong@gmail.com>
On Fri, Nov 02, 2012 at 05:31:36PM +0800, Robin Dong wrote:
> From: Robin Dong <sanbai@taobao.com>
>
> We don't need to convert tg to blkg and then convert it back in
> throtl_update_dispatch_stats().
>
> Signed-off-by: Robin Dong <sanbai@taobao.com>
> ---
Looks good to me.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
> block/blk-throttle.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/block/blk-throttle.c b/block/blk-throttle.c
> index a9664fa..46ddeff 100644
> --- a/block/blk-throttle.c
> +++ b/block/blk-throttle.c
> @@ -674,10 +674,9 @@ static bool tg_may_dispatch(struct throtl_data *td, struct throtl_grp *tg,
> return 0;
> }
>
> -static void throtl_update_dispatch_stats(struct blkcg_gq *blkg, u64 bytes,
> +static void throtl_update_dispatch_stats(struct throtl_grp *tg, u64 bytes,
> int rw)
> {
> - struct throtl_grp *tg = blkg_to_tg(blkg);
> struct tg_stats_cpu *stats_cpu;
> unsigned long flags;
>
> @@ -708,7 +707,7 @@ static void throtl_charge_bio(struct throtl_grp *tg, struct bio *bio)
> tg->bytes_disp[rw] += bio->bi_size;
> tg->io_disp[rw]++;
>
> - throtl_update_dispatch_stats(tg_to_blkg(tg), bio->bi_size, bio->bi_rw);
> + throtl_update_dispatch_stats(tg, bio->bi_size, bio->bi_rw);
> }
>
> static void throtl_add_bio_tg(struct throtl_data *td, struct throtl_grp *tg,
> @@ -1127,7 +1126,7 @@ bool blk_throtl_bio(struct request_queue *q, struct bio *bio)
> tg = throtl_lookup_tg(td, blkcg);
> if (tg) {
> if (tg_no_rule_group(tg, rw)) {
> - throtl_update_dispatch_stats(tg_to_blkg(tg),
> + throtl_update_dispatch_stats(tg,
> bio->bi_size, bio->bi_rw);
> goto out_unlock_rcu;
> }
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2012-11-02 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 9:31 [PATCH 1/2 v5] block/throttle: remove redundant type transition Robin Dong
2012-11-02 9:31 ` [PATCH 2/2 v5] block/throttle: Add IO submitted information in blkio.throttle Robin Dong
2012-11-02 20:08 ` Vivek Goyal
2012-11-02 23:07 ` Tejun Heo
2012-11-02 20:22 ` Vivek Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102202232.GU3300@redhat.com \
--to=vgoyal@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.k.dong@gmail.com \
--cc=sanbai@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox