From: Lee Jones <lee.jones@linaro.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, isdn@linux-pingi.de,
netdev@vger.kernel.org
Subject: Re: [PATCH 8/9] isdn: Remove unused variable causing a compile build warning
Date: Mon, 5 Nov 2012 10:44:50 +0100 [thread overview]
Message-ID: <20121105094450.GA5220@gmail.com> (raw)
In-Reply-To: <1352106704.1434.25.camel@x61.thuisdomein>
On Mon, 05 Nov 2012, Paul Bolle wrote:
> On Mon, 2012-11-05 at 09:44 +0100, Lee Jones wrote:
> > On Sun, 04 Nov 2012, David Miller wrote:
> > > I think the most appropriate thing to do is make CONFIG_ISDN depend
> > > upon CONFIG_NETDEVICES in the Kconfig file.
> >
> > ... and then remove the CONFIG_NETDEVICES guards in isdn_common.c?
>
> If ISDN would depend on NETDEVICES, ISDN_I4L would too, since it depends
> on ISDN. In that case CONFIG_NETDEVICES would always be true when
> compiling isdn_common.c. That would make these guards pointless. (The
> dependency of ISDN_PPP on NETDEVICES would then also be pointless.)
I'll submit a patch based on your comments.
Thanks for your time Paul.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-11-05 9:44 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-03 22:02 [PATCH 0/9] Fixups for issues when running 'make randconfig' Lee Jones
2012-11-03 22:02 ` [PATCH 1/9] ARM: integrator: Remove unused icst_params lclk_params structure Lee Jones
2012-11-03 22:02 ` [PATCH 2/9] ARM: at91: Remove unused struct at91sam9g45_isi_device and its resources Lee Jones
2012-11-04 10:15 ` Jean-Christophe PLAGNIOL-VILLARD
2012-11-04 10:57 ` Lee Jones
2012-11-05 8:13 ` Josh Wu
2012-11-05 8:19 ` Lee Jones
2012-11-03 22:02 ` [PATCH 3/9] x86: Suppress build warnings in quirks Lee Jones
2012-11-03 22:02 ` [PATCH 4/9] sched: Don't define unthrottle_offline_cfs_rqs when !CONFIG_SMP Lee Jones
2012-11-03 22:02 ` [PATCH 5/9] ASoC: Only compile adav80x codec when a bus is defined Lee Jones
2012-11-04 8:13 ` [alsa-devel] " Lars-Peter Clausen
2012-11-04 10:31 ` Lee Jones
2012-11-03 22:02 ` [PATCH 6/9] virtio_mmio: Cast &resources[1].start to ‘unsigned int *’ to rid compiler warning Lee Jones
2012-11-05 2:38 ` Rusty Russell
2012-11-05 8:21 ` Lee Jones
2012-11-05 13:00 ` Pawel Moll
2012-11-05 13:02 ` [PATCH] virtio-mmio: Fix irq parsing in command line parameter Pawel Moll
2012-11-05 13:44 ` Lee Jones
2012-11-05 14:12 ` Pawel Moll
2012-11-05 14:35 ` Lee Jones
2012-11-07 22:22 ` Rusty Russell
[not found] ` <CAF2Aj3gLLTw5ng0iZ6ecEkjGnJ-XGi3_RBrjCroW-=v=pfcFAw@mail.gmail.com>
2012-11-08 12:23 ` Rusty Russell
2012-11-03 22:02 ` [PATCH 7/9] quota: Use the pre-processor to compile out quotactl_cmd_write when !CONFIG_BLOCK Lee Jones
2012-11-06 23:06 ` Jan Kara
2012-11-03 22:02 ` [PATCH 8/9] isdn: Remove unused variable causing a compile build warning Lee Jones
2012-11-03 22:40 ` Paul Bolle
2012-11-03 22:48 ` Lee Jones
2012-11-04 10:14 ` Paul Bolle
2012-11-04 10:53 ` Lee Jones
2012-11-04 17:30 ` David Miller
2012-11-05 8:44 ` Lee Jones
2012-11-05 9:11 ` Paul Bolle
2012-11-05 9:44 ` Lee Jones [this message]
2012-11-05 16:46 ` David Miller
2012-11-05 10:31 ` [PATCH 8/9] isdn: Make CONFIG_ISDN depend on CONFIG_NETDEVICES Lee Jones
2012-11-06 23:57 ` David Miller
2012-11-07 9:56 ` Lee Jones
2012-11-04 10:28 ` [PATCH v2 8/9] isdn: Remove unused variable causing a compile build warning Lee Jones
2012-11-03 22:02 ` [PATCH 9/9] Avoid 'statement with no effect' compiler warnings Lee Jones
2012-11-04 6:00 ` David Miller
2012-11-04 7:55 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121105094450.GA5220@gmail.com \
--to=lee.jones@linaro.org \
--cc=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).