From: Alban Bedel <alban.bedel@avionic-design.de>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: linux-kernel@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
Alban Bedel <alban.bedel@avionic-design.de>
Subject: Re: [PATCH] pwm-backlight: Add support for active low PWM backlights
Date: Wed, 7 Nov 2012 13:10:37 +0100 [thread overview]
Message-ID: <20121107131037.3bd52a96@avionic-0020.adnet.avionic-design.de> (raw)
In-Reply-To: <20121106064405.GB14863@avionic-0098.mockup.avionic-design.de>
On Tue, 6 Nov 2012 07:44:06 +0100
Thierry Reding <thierry.reding@avionic-design.de> wrote:
> > --- a/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt
> > +++ b/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt
> > @@ -14,6 +14,7 @@ Required properties:
> > Optional properties:
> > - pwm-names: a list of names for the PWM devices specified in the
> > "pwms" property (see PWM binding[0])
> > + - active-low: boolean indicating that the backlight use active low logic
>
> Couldn't you use the brightness-levels property to achieve the same
> effect?
Not in the current state as the curve currently hardcode the fact the
first element have 0% duty and the last 100%. But relaxing this
limitation is probably better as it would also allow clamping the curve
like the lth_brightness parameter do when no curve is used.
I'll send a new patch implementing this soon.
Alban
prev parent reply other threads:[~2012-11-07 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 15:49 [PATCH] pwm-backlight: Add support for active low PWM backlights Alban Bedel
2012-11-06 6:44 ` Thierry Reding
2012-11-07 12:10 ` Alban Bedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121107131037.3bd52a96@avionic-0020.adnet.avionic-design.de \
--to=alban.bedel@avionic-design.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox