Re: [Xen-devel] [PATCH 1/2] xen/generic: Disable fallback build on ARM.

Jan Beulich
2012-11-07T08:38:48Z

>>> On 07.11.12 at 08:19, Ian Campbell <ian.campbell@citrix.com> wrote:
> On Tue, 2012-11-06 at 22:13 +0000, Konrad Rzeszutek Wilk wrote:
>> As there is no need for it (the fallback code is for older
>> hypervisors and they won't run under ARM),
>
> I think more specifically they won't run on anything other than x86.
>
> [...]
>> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile
>> index 46de6cd..273d2b9 100644
>> --- a/drivers/xen/Makefile
>> +++ b/drivers/xen/Makefile
>> @@ -1,8 +1,8 @@
>> ifneq ($(CONFIG_ARM),y)
>> -obj-y += manage.o balloon.o
>> +obj-y += manage.o balloon.o fallback.o
>> obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o
>> endif
>
> I think :
> obj-$(CONFIG_X86) += fallback.o
> would better reflect what is going on here.

Yes please.

Jan