From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org
Cc: Neil Brown <neilb@suse.de>, Vinod Koul <vinod.koul@intel.com>,
Dan Williams <djbw@fb.com>, Tomasz Figa <t.figa@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: [PATCH] raid5: panic() on dma_wait_for_async_tx() error
Date: Thu, 08 Nov 2012 11:06:29 +0100 [thread overview]
Message-ID: <201211081106.29980.b.zolnierkie@samsung.com> (raw)
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [PATCH] raid5: panic() on dma_wait_for_async_tx() error
There is not much we can do on dma_wait_for_async_tx() error
so just panic() for now.
Cc: Neil Brown <neilb@suse.de>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <djbw@fb.com>
Cc: Tomasz Figa <t.figa@samsung.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/md/raid5.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: b/drivers/md/raid5.c
===================================================================
--- a/drivers/md/raid5.c 2012-11-07 16:25:19.480876012 +0100
+++ b/drivers/md/raid5.c 2012-11-07 16:27:46.244875992 +0100
@@ -3223,7 +3223,9 @@ static void handle_stripe_expansion(stru
/* done submitting copies, wait for them to complete */
if (tx) {
async_tx_ack(tx);
- dma_wait_for_async_tx(tx);
+ if (dma_wait_for_async_tx(tx) != DMA_SUCCESS)
+ panic("%s: DMA error waiting for transaction\n",
+ __func__);
}
}
next reply other threads:[~2012-11-08 10:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 10:06 Bartlomiej Zolnierkiewicz [this message]
2012-11-08 11:15 ` [PATCH] raid5: panic() on dma_wait_for_async_tx() error Alan Cox
2012-11-08 11:20 ` Bartlomiej Zolnierkiewicz
2012-11-19 1:06 ` NeilBrown
2012-11-19 5:22 ` Dan Williams
2012-11-19 22:18 ` NeilBrown
2012-11-20 2:23 ` Dan Williams
2012-11-20 3:13 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211081106.29980.b.zolnierkie@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=djbw@fb.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=t.figa@samsung.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox