From: "Theodore Ts'o" <tytso@mit.edu>
To: Luming Yu <luming.yu@gmail.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/13] A simple hardware detector for latency as well as throughtput ver 0.10
Date: Thu, 8 Nov 2012 11:04:58 -0500 [thread overview]
Message-ID: <20121108160458.GC766@thunk.org> (raw)
In-Reply-To: <1352080784-30839-1-git-send-email-luming.yu@gmail.com>
On Sun, Nov 04, 2012 at 08:59:31PM -0500, Luming Yu wrote:
> Back to July of this year, I sent the first round of the tool.
> Now I've polished it a little bit.
>
> The patch is the fist step to test some basic hardware functions like
> TSC to help people understand if there is any hardware latency as well
> as throughput problem exposed on bare metal or left behind by BIOS or
> interfered by SMI. Currently the patch tests TSC, CPU Frequency, and
> RDRAND, which is a new CPU instruction to get random number introudced
> in new CPU like Intel Ivy Bridge, in stop_machine context.
You are adding a new file, drivers/misc/hw_latency_test.c to the
kernel. I don't think it makes sense to include the file, and then
follow it with 12 patches which modify the file. You don't need to
"show your work" with the various bug fixes that has been made since
July. I'd recommend collapsing all of the collected patches plus the
base file into a single commit.
Regards,
- Ted
prev parent reply other threads:[~2012-11-08 22:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 1:59 [PATCH 00/13] A simple hardware detector for latency as well as throughtput ver 0.10 Luming Yu
2012-11-05 1:59 ` [PATCH 01/13] HW-latency: hardware latency test 0.10 Luming Yu
2012-11-04 21:07 ` Maarten Lankhorst
2012-11-05 12:14 ` Luming Yu
2012-11-04 21:23 ` John Kacur
2012-11-05 12:20 ` Luming Yu
2012-11-05 8:44 ` No recipient
2012-11-05 8:44 ` Ove Karlsen
2012-11-05 1:59 ` [PATCH 02/13] HW-latency: Fix a lockdep warnning Luming Yu
2012-11-05 1:59 ` [PATCH 03/13] HW-latency: Use get_random_bytes_arch Luming Yu
2012-11-05 1:59 ` [PATCH 04/13] HW-latency: Differentiate three modes to use CPU carry out testing Luming Yu
2012-11-05 1:59 ` [PATCH 05/13] HW-latency: Add CPU field in sample output Luming Yu
2012-11-05 1:59 ` [PATCH 06/13] HW-latency: cycle through all online cpus to re-test cpufreq Luming Yu
2012-11-05 1:59 ` [PATCH 07/13] HW-latency: delete too many "Fast TSC calibration using PIT" in cpufreq sampling Luming Yu
2012-11-05 1:59 ` [PATCH 08/13] HW-latency: A stupid memory scanner for raw memory latency test Luming Yu
2012-11-05 1:59 ` [PATCH 09/13] HW-latency: Fix unwanted crash caused by write to dummy debugfs interface Luming Yu
2012-11-05 1:59 ` [PATCH 10/13] HW-latency: add address range for x86-32 Luming Yu
2012-11-05 1:59 ` [PATCH 11/13] HW-latency: fix a warnning in previous patch Luming Yu
2012-11-05 1:59 ` [PATCH 12/13] HW-latency: Add sample unit in sample data Luming Yu
2012-11-05 1:59 ` [PATCH 13/13] HW-latency: some sample data format change Luming Yu
2012-11-08 16:04 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121108160458.GC766@thunk.org \
--to=tytso@mit.edu \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luming.yu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox