From: Arpith Easow Alexander <arpith99@gmail.com>
To: abbotti@mev.co.uk, fmhess@users.sourceforge.net,
gregkh@linuxfoundation.org, hsweeten@visionengravers.com,
dan.carpenter@oracle.com, arpith99@gmail.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Staging: comedi: drivers: replaced printk with dev_dbg
Date: Sat, 10 Nov 2012 12:38:38 +0530 [thread overview]
Message-ID: <20121110070833.GA18391@gmail.com> (raw)
This is a patch to the vmk80xx.c file that replaces the printk with dev_dbg.
This fixes the warnings found by the checkpatch.pl tool.
Signed-off-by: Arpith Easow Alexander <arpith99@gmail.com>
---
drivers/staging/comedi/drivers/vmk80xx.c | 30 ++++++++++++++++++------------
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/comedi/drivers/vmk80xx.c b/drivers/staging/comedi/drivers/vmk80xx.c
index df277aa..6eb5361 100644
--- a/drivers/staging/comedi/drivers/vmk80xx.c
+++ b/drivers/staging/comedi/drivers/vmk80xx.c
@@ -131,10 +131,10 @@ static int dbgcm = 1;
static int dbgcm;
#endif
-#define dbgcm(fmt, arg...) \
+#define dbgcm(dev, fmt, arg...) \
do { \
if (dbgcm) \
- printk(KERN_DEBUG fmt, ##arg); \
+ dev_dbg(dev, fmt, ##arg); \
} while (0)
enum vmk80xx_model {
@@ -213,8 +213,9 @@ static void vmk80xx_tx_callback(struct urb *urb)
if (stat && !(stat == -ENOENT
|| stat == -ECONNRESET || stat == -ESHUTDOWN))
- dbgcm("comedi#: vmk80xx: %s - nonzero urb status (%d)\n",
- __func__, stat);
+ dbgcm(&(dev->udev->dev),
+ "comedi#: vmk80xx: %s - nonzero urb status (%d)\n",
+ __func__, stat);
if (!test_bit(TRANS_OUT_BUSY, &dev->flags))
return;
@@ -237,7 +238,8 @@ static void vmk80xx_rx_callback(struct urb *urb)
case -ESHUTDOWN:
break;
default:
- dbgcm("comedi#: vmk80xx: %s - nonzero urb status (%d)\n",
+ dbgcm(&(dev->udev->dev),
+ "comedi#: vmk80xx: %s - nonzero urb status (%d)\n",
__func__, stat);
goto resubmit;
}
@@ -1371,14 +1373,16 @@ static int vmk80xx_usb_probe(struct usb_interface *intf,
if (dev->board.model == VMK8061_MODEL) {
vmk80xx_read_eeprom(dev, IC3_VERSION);
- printk(KERN_INFO "comedi#: vmk80xx: %s\n", dev->fw.ic3_vers);
+ dev_dbg(&(dev->udev->dev),
+ "comedi#: vmk80xx: %s\n", dev->fw.ic3_vers);
if (vmk80xx_check_data_link(dev)) {
vmk80xx_read_eeprom(dev, IC6_VERSION);
- printk(KERN_INFO "comedi#: vmk80xx: %s\n",
+ dev_dbg(&(dev->udev->dev), "comedi#: vmk80xx: %s\n",
dev->fw.ic6_vers);
} else {
- dbgcm("comedi#: vmk80xx: no conn. to CPU\n");
+ dbgcm(&(dev->udev->dev),
+ "comedi#: vmk80xx: no conn. to CPU\n");
}
}
@@ -1387,8 +1391,9 @@ static int vmk80xx_usb_probe(struct usb_interface *intf,
dev->probed = 1;
- printk(KERN_INFO "comedi#: vmk80xx: board #%d [%s] now attached\n",
- dev->count, dev->board.name);
+ dev_dbg(&(dev->udev->dev),
+ "comedi#: vmk80xx: board #%d [%s] now attached\n",
+ dev->count, dev->board.name);
mutex_unlock(&glb_mutex);
@@ -1422,8 +1427,9 @@ static void vmk80xx_usb_disconnect(struct usb_interface *intf)
kfree(dev->usb_rx_buf);
kfree(dev->usb_tx_buf);
- printk(KERN_INFO "comedi#: vmk80xx: board #%d [%s] now detached\n",
- dev->count, dev->board.name);
+ dev_dbg(&(dev->udev->dev),
+ "comedi#: vmk80xx: board #%d [%s] now detached\n",
+ dev->count, dev->board.name);
up(&dev->limit_sem);
mutex_unlock(&glb_mutex);
--
1.7.9.5
next reply other threads:[~2012-11-10 7:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-10 7:08 Arpith Easow Alexander [this message]
2012-11-13 19:52 ` [PATCH] Staging: comedi: drivers: replaced printk with dev_dbg Greg KH
2012-11-15 16:27 ` Arpith Easow Alexander
2012-11-15 16:34 ` H Hartley Sweeten
2012-11-15 23:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121110070833.GA18391@gmail.com \
--to=arpith99@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).