From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear
Date: Sun, 11 Nov 2012 09:58:41 +0100 [thread overview]
Message-ID: <20121111095841.285784c0@skate> (raw)
In-Reply-To: <1352590084.14983.1.camel@phoenix>
Axel,
On Sun, 11 Nov 2012 07:28:04 +0800, Axel Lin wrote:
> Current implementation in dove_audio1_ctrl_set() does not clear corresponding
> register bit if BIT(0|1|2|3) of config is clear. Fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi,
> I don't have this hardware.
> I'd appreciate if someone can review and test this patch.
>
> Thanks,
> Axel
> drivers/pinctrl/mvebu/pinctrl-dove.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
The patches against pinctrl-dove need to be reviewed and acked by
Sebastian Hesselbarth, he is the one who has written this code and who
has access to Dove hardware. Could you repost and Cc him, as well as
linux-arm-kernel@ ?
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-11-11 8:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-10 23:28 [PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear Axel Lin
2012-11-10 23:29 ` [PATCH RFT 2/2] pinctrl: dove: Checking valid config in dove_audio1_ctrl_set Axel Lin
2012-11-11 8:58 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-11-11 13:44 [PATCH RFT 1/2] pinctrl: dove: Fix dove_audio1_ctrl_set when BIT(0|1|2|3) of config is clear Axel Lin
2012-11-12 9:39 ` Sebastian Hesselbarth
2012-11-16 9:12 ` Axel Lin
2012-11-16 18:32 ` Sebastian Hesselbarth
2012-11-17 1:22 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121111095841.285784c0@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=axel.lin@ingics.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox