From: "Hans J. Koch" <hjk@hansjkoch.de>
To: Manuel Traut <manut@linutronix.de>
Cc: linux-kernel@vger.kernel.org, "Hans J. Koch" <hjk@hansjkoch.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stefan Staedtler <stefan.staedtler@siemens.com>,
Magnus Damm <magnus.damm@gmail.com>,
Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] uio_pdrv: set memory mapping name
Date: Sun, 11 Nov 2012 13:43:10 +0100 [thread overview]
Message-ID: <20121111124310.GA4313@local> (raw)
In-Reply-To: <20121109060640.GW15531@linutronix.de>
On Fri, Nov 09, 2012 at 07:06:40AM +0100, Manuel Traut wrote:
> If uio_pdrv[_genirq] is used, the uio maps have currently no name set.
> This patch sets the uio_mem name to the name of the memory resource.
Looks fine to me. I added the driver's authors to Cc.
Signed-off-by: "Hans J. Koch" <hjk@hansjkoch.de>
>
> Signed-off-by: Manuel Traut <manut@linutronix.de>
> Reported-by: Stefan Staedtler <stefan.staedtler@siemens.com>
> Tested-by: Stefan Staedtler <stefan.staedtler@siemens.com>
>
> diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c
> index 42202cd..ac988ce 100644
> --- a/drivers/uio/uio_pdrv_genirq.c
> +++ b/drivers/uio/uio_pdrv_genirq.c
> @@ -172,6 +172,7 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev)
> uiomem->memtype = UIO_MEM_PHYS;
> uiomem->addr = r->start;
> uiomem->size = resource_size(r);
> + uiomem->name = r->name;
> ++uiomem;
> }
>
> diff --git a/drivers/uio/uio_pdrv.c b/drivers/uio/uio_pdrv.c
> index 72d3646..39be9e0 100644
> --- a/drivers/uio/uio_pdrv.c
> +++ b/drivers/uio/uio_pdrv.c
> @@ -60,6 +60,7 @@ static int uio_pdrv_probe(struct platform_device *pdev)
> uiomem->memtype = UIO_MEM_PHYS;
> uiomem->addr = r->start;
> uiomem->size = resource_size(r);
> + uiomem->name = r->name;
> ++uiomem;
> }
>
>
prev parent reply other threads:[~2012-11-11 12:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 6:06 [PATCH] uio_pdrv: set memory mapping name Manuel Traut
2012-11-11 12:43 ` Hans J. Koch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121111124310.GA4313@local \
--to=hjk@hansjkoch.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=manut@linutronix.de \
--cc=stefan.staedtler@siemens.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox