From: Samuel Ortiz <sameo@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: David Dajun Chen <dchen@diasemi.com>,
Ashish Jangam <ashish.jangam@kpitcummins.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd/DA9055: Remove Unicode Byte Order Marks
Date: Mon, 12 Nov 2012 00:55:47 +0100 [thread overview]
Message-ID: <20121111235547.GI27828@sortiz-mobl> (raw)
In-Reply-To: <1350333885-20323-1-git-send-email-geert@linux-m68k.org>
Hi Geert,
On Mon, Oct 15, 2012 at 10:44:45PM +0200, Geert Uytterhoeven wrote:
> Older gcc (< 4.4) doesn't like files starting with Unicode BOMs:
>
> include/linux/mfd/da9055/core.h:1: error: stray ‘\357’ in program
> include/linux/mfd/da9055/core.h:1: error: stray ‘\273’ in program
> include/linux/mfd/da9055/core.h:1: error: stray ‘\277’ in program
> include/linux/mfd/da9055/pdata.h:1: error: stray ‘\357’ in program
> include/linux/mfd/da9055/pdata.h:1: error: stray ‘\273’ in program
> include/linux/mfd/da9055/pdata.h:1: error: stray ‘\277’ in program
> include/linux/mfd/da9055/reg.h:1: error: stray ‘\357’ in program
> include/linux/mfd/da9055/reg.h:1: error: stray ‘\273’ in program
> include/linux/mfd/da9055/reg.h:1: error: stray ‘\277’ in program
>
> Remove the BOMs, the rest of the files is plain ASCII anyway.
>
> Output of "file" before:
>
> include/linux/mfd/da9055/core.h: UTF-8 Unicode (with BOM) C program text
> include/linux/mfd/da9055/pdata.h: UTF-8 Unicode (with BOM) C program text
> include/linux/mfd/da9055/reg.h: UTF-8 Unicode (with BOM) C program text
>
> Output of "file" after:
>
> include/linux/mfd/da9055/core.h: ASCII C program text
> include/linux/mfd/da9055/pdata.h: ASCII C program text
> include/linux/mfd/da9055/reg.h: ASCII C program text
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> include/linux/mfd/da9055/core.h | 2 +-
> include/linux/mfd/da9055/pdata.h | 2 +-
> include/linux/mfd/da9055/reg.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
Applied to my for-next branch, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2012-11-11 23:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 20:44 [PATCH] mfd/DA9055: Remove Unicode Byte Order Marks Geert Uytterhoeven
2012-11-11 9:41 ` Geert Uytterhoeven
2012-11-11 23:55 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121111235547.GI27828@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=dchen@diasemi.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox