* [PATCH] mfd/DA9055: Remove Unicode Byte Order Marks
@ 2012-10-15 20:44 Geert Uytterhoeven
2012-11-11 9:41 ` Geert Uytterhoeven
2012-11-11 23:55 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2012-10-15 20:44 UTC (permalink / raw)
To: David Dajun Chen, Ashish Jangam, Samuel Ortiz
Cc: linux-kernel, Geert Uytterhoeven
Older gcc (< 4.4) doesn't like files starting with Unicode BOMs:
include/linux/mfd/da9055/core.h:1: error: stray ‘\357’ in program
include/linux/mfd/da9055/core.h:1: error: stray ‘\273’ in program
include/linux/mfd/da9055/core.h:1: error: stray ‘\277’ in program
include/linux/mfd/da9055/pdata.h:1: error: stray ‘\357’ in program
include/linux/mfd/da9055/pdata.h:1: error: stray ‘\273’ in program
include/linux/mfd/da9055/pdata.h:1: error: stray ‘\277’ in program
include/linux/mfd/da9055/reg.h:1: error: stray ‘\357’ in program
include/linux/mfd/da9055/reg.h:1: error: stray ‘\273’ in program
include/linux/mfd/da9055/reg.h:1: error: stray ‘\277’ in program
Remove the BOMs, the rest of the files is plain ASCII anyway.
Output of "file" before:
include/linux/mfd/da9055/core.h: UTF-8 Unicode (with BOM) C program text
include/linux/mfd/da9055/pdata.h: UTF-8 Unicode (with BOM) C program text
include/linux/mfd/da9055/reg.h: UTF-8 Unicode (with BOM) C program text
Output of "file" after:
include/linux/mfd/da9055/core.h: ASCII C program text
include/linux/mfd/da9055/pdata.h: ASCII C program text
include/linux/mfd/da9055/reg.h: ASCII C program text
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
include/linux/mfd/da9055/core.h | 2 +-
include/linux/mfd/da9055/pdata.h | 2 +-
include/linux/mfd/da9055/reg.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/mfd/da9055/core.h b/include/linux/mfd/da9055/core.h
index c96ad68..956afa4 100644
--- a/include/linux/mfd/da9055/core.h
+++ b/include/linux/mfd/da9055/core.h
@@ -1,4 +1,4 @@
-/*
+/*
* da9055 declarations for DA9055 PMICs.
*
* Copyright(c) 2012 Dialog Semiconductor Ltd.
diff --git a/include/linux/mfd/da9055/pdata.h b/include/linux/mfd/da9055/pdata.h
index 147293b..b9b204e 100644
--- a/include/linux/mfd/da9055/pdata.h
+++ b/include/linux/mfd/da9055/pdata.h
@@ -1,4 +1,4 @@
-/* Copyright (C) 2012 Dialog Semiconductor Ltd.
+/* Copyright (C) 2012 Dialog Semiconductor Ltd.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
diff --git a/include/linux/mfd/da9055/reg.h b/include/linux/mfd/da9055/reg.h
index df237ee..2b592e0 100644
--- a/include/linux/mfd/da9055/reg.h
+++ b/include/linux/mfd/da9055/reg.h
@@ -1,4 +1,4 @@
-/*
+/*
* DA9055 declarations for DA9055 PMICs.
*
* Copyright(c) 2012 Dialog Semiconductor Ltd.
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd/DA9055: Remove Unicode Byte Order Marks
2012-10-15 20:44 [PATCH] mfd/DA9055: Remove Unicode Byte Order Marks Geert Uytterhoeven
@ 2012-11-11 9:41 ` Geert Uytterhoeven
2012-11-11 23:55 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2012-11-11 9:41 UTC (permalink / raw)
To: David Dajun Chen, Ashish Jangam, Samuel Ortiz, Andrew Morton
Cc: linux-kernel, Geert Uytterhoeven
Ping? (akpm added to CC)
On Mon, Oct 15, 2012 at 10:44 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Older gcc (< 4.4) doesn't like files starting with Unicode BOMs:
>
> include/linux/mfd/da9055/core.h:1: error: stray ‘\357’ in program
> include/linux/mfd/da9055/core.h:1: error: stray ‘\273’ in program
> include/linux/mfd/da9055/core.h:1: error: stray ‘\277’ in program
> include/linux/mfd/da9055/pdata.h:1: error: stray ‘\357’ in program
> include/linux/mfd/da9055/pdata.h:1: error: stray ‘\273’ in program
> include/linux/mfd/da9055/pdata.h:1: error: stray ‘\277’ in program
> include/linux/mfd/da9055/reg.h:1: error: stray ‘\357’ in program
> include/linux/mfd/da9055/reg.h:1: error: stray ‘\273’ in program
> include/linux/mfd/da9055/reg.h:1: error: stray ‘\277’ in program
>
> Remove the BOMs, the rest of the files is plain ASCII anyway.
>
> Output of "file" before:
>
> include/linux/mfd/da9055/core.h: UTF-8 Unicode (with BOM) C program text
> include/linux/mfd/da9055/pdata.h: UTF-8 Unicode (with BOM) C program text
> include/linux/mfd/da9055/reg.h: UTF-8 Unicode (with BOM) C program text
>
> Output of "file" after:
>
> include/linux/mfd/da9055/core.h: ASCII C program text
> include/linux/mfd/da9055/pdata.h: ASCII C program text
> include/linux/mfd/da9055/reg.h: ASCII C program text
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> include/linux/mfd/da9055/core.h | 2 +-
> include/linux/mfd/da9055/pdata.h | 2 +-
> include/linux/mfd/da9055/reg.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/mfd/da9055/core.h b/include/linux/mfd/da9055/core.h
> index c96ad68..956afa4 100644
> --- a/include/linux/mfd/da9055/core.h
> +++ b/include/linux/mfd/da9055/core.h
> @@ -1,4 +1,4 @@
> -/*
> +/*
> * da9055 declarations for DA9055 PMICs.
> *
> * Copyright(c) 2012 Dialog Semiconductor Ltd.
> diff --git a/include/linux/mfd/da9055/pdata.h b/include/linux/mfd/da9055/pdata.h
> index 147293b..b9b204e 100644
> --- a/include/linux/mfd/da9055/pdata.h
> +++ b/include/linux/mfd/da9055/pdata.h
> @@ -1,4 +1,4 @@
> -/* Copyright (C) 2012 Dialog Semiconductor Ltd.
> +/* Copyright (C) 2012 Dialog Semiconductor Ltd.
> *
> * This program is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License as published by
> diff --git a/include/linux/mfd/da9055/reg.h b/include/linux/mfd/da9055/reg.h
> index df237ee..2b592e0 100644
> --- a/include/linux/mfd/da9055/reg.h
> +++ b/include/linux/mfd/da9055/reg.h
> @@ -1,4 +1,4 @@
> -/*
> +/*
> * DA9055 declarations for DA9055 PMICs.
> *
> * Copyright(c) 2012 Dialog Semiconductor Ltd.
> --
> 1.7.0.4
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd/DA9055: Remove Unicode Byte Order Marks
2012-10-15 20:44 [PATCH] mfd/DA9055: Remove Unicode Byte Order Marks Geert Uytterhoeven
2012-11-11 9:41 ` Geert Uytterhoeven
@ 2012-11-11 23:55 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2012-11-11 23:55 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: David Dajun Chen, Ashish Jangam, linux-kernel
Hi Geert,
On Mon, Oct 15, 2012 at 10:44:45PM +0200, Geert Uytterhoeven wrote:
> Older gcc (< 4.4) doesn't like files starting with Unicode BOMs:
>
> include/linux/mfd/da9055/core.h:1: error: stray ‘\357’ in program
> include/linux/mfd/da9055/core.h:1: error: stray ‘\273’ in program
> include/linux/mfd/da9055/core.h:1: error: stray ‘\277’ in program
> include/linux/mfd/da9055/pdata.h:1: error: stray ‘\357’ in program
> include/linux/mfd/da9055/pdata.h:1: error: stray ‘\273’ in program
> include/linux/mfd/da9055/pdata.h:1: error: stray ‘\277’ in program
> include/linux/mfd/da9055/reg.h:1: error: stray ‘\357’ in program
> include/linux/mfd/da9055/reg.h:1: error: stray ‘\273’ in program
> include/linux/mfd/da9055/reg.h:1: error: stray ‘\277’ in program
>
> Remove the BOMs, the rest of the files is plain ASCII anyway.
>
> Output of "file" before:
>
> include/linux/mfd/da9055/core.h: UTF-8 Unicode (with BOM) C program text
> include/linux/mfd/da9055/pdata.h: UTF-8 Unicode (with BOM) C program text
> include/linux/mfd/da9055/reg.h: UTF-8 Unicode (with BOM) C program text
>
> Output of "file" after:
>
> include/linux/mfd/da9055/core.h: ASCII C program text
> include/linux/mfd/da9055/pdata.h: ASCII C program text
> include/linux/mfd/da9055/reg.h: ASCII C program text
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> include/linux/mfd/da9055/core.h | 2 +-
> include/linux/mfd/da9055/pdata.h | 2 +-
> include/linux/mfd/da9055/reg.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
Applied to my for-next branch, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-11 23:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-15 20:44 [PATCH] mfd/DA9055: Remove Unicode Byte Order Marks Geert Uytterhoeven
2012-11-11 9:41 ` Geert Uytterhoeven
2012-11-11 23:55 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox