public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@linaro.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Dong Aisheng <dong.aisheng@linaro.org>,
	Devendra Naga <devendra.aaru@gmail.com>,
	Stephen Warren <swarren@nvidia.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] pinctrl: mxs: Make PINCTRL_MXS select PINMUX && PINCONF
Date: Mon, 12 Nov 2012 09:46:16 +0800	[thread overview]
Message-ID: <20121112014615.GA415@S2100-06.ap.freescale.net> (raw)
In-Reply-To: <1352600562.23129.3.camel@phoenix>

On Sun, Nov 11, 2012 at 10:22:42AM +0800, Axel Lin wrote:
> Then we can remove "select PINMUX && PINCONF" from PINCTRL_IMX{23,28}.
> This simplifies the dependency.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/pinctrl/Kconfig |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index fc0f49a..d5c9431 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -99,18 +99,16 @@ config PINCTRL_MMP2
>  	select PINCONF
>  
>  config PINCTRL_MXS
> +	select PINMUX
> +	select PINCONF

Better have them after 'bool' below, otherwise,

Acked-by: Shawn Guo <shawn.guo@linaro.org>

>  	bool
>  
>  config PINCTRL_IMX23
>  	bool
> -	select PINMUX
> -	select PINCONF
>  	select PINCTRL_MXS
>  
>  config PINCTRL_IMX28
>  	bool
> -	select PINMUX
> -	select PINCONF
>  	select PINCTRL_MXS
>  
>  config PINCTRL_NOMADIK
> -- 
> 1.7.9.5
> 
> 
> 


  reply	other threads:[~2012-11-12  1:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-11  2:21 [PATCH 1/2] pinctrl: tegra: Make PINCTRL_TEGRA select PINMUX && PINCONF Axel Lin
2012-11-11  2:22 ` [PATCH 2/2] pinctrl: mxs: Make PINCTRL_MXS " Axel Lin
2012-11-12  1:46   ` Shawn Guo [this message]
2012-11-12 16:14 ` [PATCH 1/2] pinctrl: tegra: Make PINCTRL_TEGRA " Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121112014615.GA415@S2100-06.ap.freescale.net \
    --to=shawn.guo@linaro.org \
    --cc=axel.lin@ingics.com \
    --cc=devendra.aaru@gmail.com \
    --cc=dong.aisheng@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox