From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: sameo@linux.intel.com, lrg@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/2] mfd: add TI TPS80031 mfd core driver
Date: Tue, 13 Nov 2012 16:46:24 +0900 [thread overview]
Message-ID: <20121113074623.GL18224@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1352646721-8350-2-git-send-email-ldewangan@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On Sun, Nov 11, 2012 at 08:42:00PM +0530, Laxman Dewangan wrote:
> +#define TPS80031_RGEMAP_IRQ(_reg, _mask) \
Why RGEMAP_IRQ?
> +static struct regmap_irq_chip tps80031_irq_chip = {
> + .name = "tps80031",
> + .irqs = tps80031_main_irqs,
> + .num_irqs = ARRAY_SIZE(tps80031_main_irqs),
> + .num_regs = 3,
> + .status_base = TPS80031_INT_STS_A,
> + .mask_base = TPS80031_INT_MSK_LINE_A,
> + .wake_base = 1,
I'm not sure your wake_base setting is sane here - this is expected to
be a register. If it is a register why is it not a #define?
> +static int __devinit tps80031_irq_init(struct tps80031 *tps80031, int irq,
> + int irq_base)
> +{
> + struct device *dev = tps80031->dev;
> + int i, ret;
> +
> + for (i = 0; i < 3; i++)
> + tps80031_write(dev, SLAVE_ID2,
> + TPS80031_INT_MSK_STS_A + i, 0x00);
regmap ought to be masking everything for you on init.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-13 7:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 15:11 [PATCH V3 0/2] tps80031: Add mfd and regulator driver Laxman Dewangan
2012-11-11 15:12 ` [PATCH V3 1/2] mfd: add TI TPS80031 mfd core driver Laxman Dewangan
2012-11-12 11:30 ` Guennadi Liakhovetski
2012-11-13 7:46 ` Mark Brown [this message]
2012-11-13 17:48 ` Laxman Dewangan
2012-11-14 1:22 ` Mark Brown
2012-11-14 2:35 ` Laxman Dewangan
2012-11-14 2:45 ` Mark Brown
2012-11-14 3:01 ` Laxman Dewangan
2012-11-14 3:04 ` Mark Brown
2012-11-14 3:51 ` Laxman Dewangan
2012-11-11 15:12 ` [PATCH V3 2/2] regulator: tps80031: add regulator driver for tps80031 Laxman Dewangan
2012-11-12 12:28 ` Guennadi Liakhovetski
2012-11-13 6:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113074623.GL18224@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).