Re: [PATCH] Staging: comedi: drivers: replaced printk with dev_dbg

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Nov 10, 2012 at 12:38:38PM +0530, Arpith Easow Alexander wrote:
> This is a patch to the vmk80xx.c file that replaces the printk with dev_dbg.
> This fixes the warnings found by the checkpatch.pl tool.
> 
> Signed-off-by: Arpith Easow Alexander <arpith99@gmail.com>
> ---
>  drivers/staging/comedi/drivers/vmk80xx.c |   30 ++++++++++++++++++------------
>  1 file changed, 18 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/vmk80xx.c b/drivers/staging/comedi/drivers/vmk80xx.c
> index df277aa..6eb5361 100644
> --- a/drivers/staging/comedi/drivers/vmk80xx.c
> +++ b/drivers/staging/comedi/drivers/vmk80xx.c
> @@ -131,10 +131,10 @@ static int dbgcm = 1;
>  static int dbgcm;
>  #endif
>  
> -#define dbgcm(fmt, arg...)                     \
> +#define dbgcm(dev, fmt, arg...)                     \
>  do {                                           \
>  	if (dbgcm)                             \
> -		printk(KERN_DEBUG fmt, ##arg); \
> +		dev_dbg(dev, fmt, ##arg); \

So a macro called dbgcm tests a variable called dbgcm?  Gotta love c at
times...

Just delete the macro, and the variable, and call dev_dbg() directly
please.

thanks.

greg k-h