From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: lrg@ti.com, ldewangan@nvidia.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] regulator: core: Avoid deadlock when regulator_register fails
Date: Wed, 14 Nov 2012 19:01:49 +0900 [thread overview]
Message-ID: <20121114100147.GH7407@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20121114093931.GA23525@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
On Wed, Nov 14, 2012 at 09:39:31AM +0000, Charles Keepax wrote:
> When regulator_register fails and exits through the scrub path the
> regulator_put function was called whilst holding the
> regulator_list_mutex, causing deadlock.
Applied, thanks.
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
Please avoid doing this. I know a lot of people do but it makes for
hand editing of the commit log to remove it.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-11-14 10:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 10:34 [PATCH] regulator: core: avoid memory access after freeing it Laxman Dewangan
2012-11-06 11:12 ` Charles Keepax
2012-11-06 11:31 ` Mark Brown
2012-11-13 16:30 ` [PATCH] regulator: core: Add locked version of regulator_put to avoid deadlock Charles Keepax
2012-11-13 17:16 ` Laxman Dewangan
2012-11-13 23:25 ` Mark Brown
2012-11-14 9:39 ` [PATCH v2] regulator: core: Avoid deadlock when regulator_register fails Charles Keepax
2012-11-14 10:01 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114100147.GH7407@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).