From: Dan Carpenter <dan.carpenter@oracle.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: devel@driverdev.osuosl.org,
line6linux-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Daniel Mack <zonque@gmail.com>,
Markus Grabner <grabner@icg.tugraz.at>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/3] staging: line6: replace DEBUG_MESSAGES() with dev_dbg()
Date: Wed, 14 Nov 2012 17:40:41 +0300 [thread overview]
Message-ID: <20121114144041.GI11515@mwanda> (raw)
In-Reply-To: <1352638346-32273-2-git-send-email-stefanha@gmail.com>
On Sun, Nov 11, 2012 at 01:52:24PM +0100, Stefan Hajnoczi wrote:
> + dev_dbg(pod->line6.ifcdev,
> + "wrong size of channel dump message (%d instead of %d)\n",
> + pod->line6.message_length,
> + (int)sizeof(pod->prog_data) +
> + 7);
Better to get rid of the cast. You're already over the 80 character
limit so putting the "7);" on the line before is ok.
regards,
dan carpenter
next prev parent reply other threads:[~2012-11-14 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 12:52 [PATCH 0/3] staging: line6: replace CONFIG_LINE6_USB_DEBUG with dyndbg Stefan Hajnoczi
2012-11-11 12:52 ` [PATCH 1/3] staging: line6: replace DEBUG_MESSAGES() with dev_dbg() Stefan Hajnoczi
2012-11-14 14:40 ` Dan Carpenter [this message]
2012-11-11 12:52 ` [PATCH 2/3] staging: line6: drop unused DEBUG_MESSAGES() macro Stefan Hajnoczi
2012-11-11 12:52 ` [PATCH 3/3] staging: line6: drop unused CONFIG_LINE6_USB_DEBUG Stefan Hajnoczi
2012-11-11 12:54 ` [PATCH 0/3] staging: line6: replace CONFIG_LINE6_USB_DEBUG with dyndbg Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114144041.GI11515@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=grabner@icg.tugraz.at \
--cc=gregkh@linuxfoundation.org \
--cc=line6linux-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanha@gmail.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).