From: Arnd Bergmann <arnd@arndb.de>
To: Rob Clark <rob.clark@linaro.org>
Cc: "Russell King - ARM Linux" <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org, patches@linaro.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] ARM: add get_user() support for 8 byte types
Date: Thu, 15 Nov 2012 14:39:41 +0000 [thread overview]
Message-ID: <201211151439.41393.arnd@arndb.de> (raw)
In-Reply-To: <CAF6AEGuJReNtwUZX6HVZCE8GHuyEAyC8bM0GqZuVMV1=DrGJVw@mail.gmail.com>
On Thursday 15 November 2012, Rob Clark wrote:
> > I still haven't heard a conclusive argument why we need to use get_user()
> > rather than copy_from_user() in the DRM code. Is this about a fast path
> > where you want to shave off a few cycles for each call, or does this
> > simplify the code structure, or something else?
>
> well, it is mostly because it seemed like a good idea to first try to
> solve the root issue, rather than having to fix things up in each
> driver when someone from x86-world introduces a 64b get_user()..
As pointed out by hpa earlier, x86-32 doesn't have a 64b get_user
either. I don't think we have a lot of drivers that are used only
on 64-bit x86 and on 32-bit ARM but not on 32-bit x86.
> There are some other arch's that don't have 64b get_user(), but I
> don't think any that have any DRM drivers. If 64b get_user() is
> really not intended to be supported by all archs, it is better to
> remove it from x86 and the other arch's that do currently support it,
> rather than making it possible to write drivers that are broken on
> some archs.
The majority of architectures we support have PCI and should be able
to build the regular (radeon, nouveau, MGA, VIA, ...) DRM drivers
AFAICT.
Arnd
next prev parent reply other threads:[~2012-11-15 14:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 21:17 [PATCH] ARM: add get_user() support for 8 byte types Rob Clark
2012-11-12 10:46 ` Will Deacon
2012-11-12 13:46 ` Rob Clark
2012-11-12 14:38 ` Will Deacon
2012-11-12 15:09 ` Rob Clark
2012-11-12 19:27 ` Russell King - ARM Linux
2012-11-12 19:58 ` Rob Clark
2012-11-12 23:08 ` Russell King - ARM Linux
2012-11-12 23:33 ` Rob Clark
2012-11-12 23:53 ` Russell King - ARM Linux
2012-11-13 0:31 ` Rob Clark
2012-11-13 9:11 ` Arnd Bergmann
2012-11-13 11:24 ` Russell King - ARM Linux
2012-11-15 9:19 ` Arnd Bergmann
2012-11-15 13:04 ` Rob Clark
2012-11-15 13:39 ` Arnd Bergmann
2012-11-15 13:46 ` Rob Clark
2012-11-15 14:39 ` Arnd Bergmann [this message]
2012-11-19 14:32 ` Ville Syrjälä
2012-11-19 14:48 ` Russell King - ARM Linux
2012-11-19 15:18 ` Ville Syrjälä
2012-11-13 11:04 ` Russell King - ARM Linux
-- strict thread matches above, loose matches on Subject: below --
2012-11-13 15:00 Rob Clark
2012-11-15 22:01 Rob Clark
2012-11-15 22:22 ` Nicolas Pitre
2012-11-16 8:18 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211151439.41393.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=patches@linaro.org \
--cc=rob.clark@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox