From: Dan Carpenter <dan.carpenter@oracle.com>
To: YAMANE Toshiaki <yamanetoshi@gmail.com>
Cc: devel@driverdev.osuosl.org,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH 2/4] staging/serqt_usb2: refactor qt_read_bulk_callback() in serqt_usb2.c
Date: Thu, 15 Nov 2012 23:43:34 +0300 [thread overview]
Message-ID: <20121115204333.GJ11566@mwanda> (raw)
In-Reply-To: <CAOTypNR3Wa1rpc45kG2W1Yv-6rXD==kxx+m9TC=94m08EefkoQ@mail.gmail.com>
Btw:
> + dev_dbg(&port->dev, "Line status status.\n");
^^^^^^^^^^^^^^^^^^^
These kind of debug statements which just tell which function is
being called can be deleted. The function tracer already provides
that information.
> + fn = ProcessLineStatus;
> + } else {
> + dev_dbg(&port->dev, "Modem status status.\n");
> + fn = ProcessModemStatus;
regards,
dan carpenter
next prev parent reply other threads:[~2012-11-15 22:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 21:33 [PATCH 1/4] staging/serqt_usb2: fixed line over issue in serqt_usb2.c YAMANE Toshiaki
2012-11-09 21:33 ` [PATCH 2/4] staging/serqt_usb2: refactor qt_read_bulk_callback() " YAMANE Toshiaki
2012-11-14 12:41 ` Dan Carpenter
2012-11-14 20:09 ` YAMANE Toshiaki
2012-11-15 20:01 ` YAMANE Toshiaki
2012-11-15 20:18 ` Dan Carpenter
2012-11-15 20:32 ` YAMANE Toshiaki
2012-11-15 20:43 ` Dan Carpenter [this message]
2012-11-15 20:53 ` YAMANE Toshiaki
2012-11-09 21:34 ` [PATCH 3/4] staging/serqt_usb2: refactor qt_open() " YAMANE Toshiaki
2012-11-09 21:34 ` [PATCH 4/4] staging/serqt_usb2: refactor qt_unthrottle() " YAMANE Toshiaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115204333.GJ11566@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=stern@rowland.harvard.edu \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox