From: Greg KH <gregkh@linuxfoundation.org>
To: George Zhang <georgezhang@vmware.com>
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, pv-drivers@vmware.com
Subject: Re: [PATCH 02/12] VMCI: datagram implementation.
Date: Thu, 15 Nov 2012 15:47:14 -0800 [thread overview]
Message-ID: <20121115234714.GA8005@kroah.com> (raw)
In-Reply-To: <20121107184116.9658.20579.stgit@promb-2n-dhcp175.eng.vmware.com>
On Wed, Nov 07, 2012 at 10:41:26AM -0800, George Zhang wrote:
> +/*
> + * Create a datagram entry given a handle pointer.
> + */
> +static int dg_create_handle(u32 resource_id,
> + u32 flags,
> + u32 priv_flags,
> + vmci_datagram_recv_cb recv_cb,
> + void *client_data, struct vmci_handle *out_handle)
> +{
> + int result;
> + u32 context_id;
> + struct vmci_handle handle;
> + struct datagram_entry *entry;
> +
> + BUG_ON(!recv_cb);
> + BUG_ON(!out_handle);
> + BUG_ON(priv_flags & ~VMCI_PRIVILEGE_ALL_FLAGS);
Given that this is a static function, there's no need for these
"asserts", right? Please send a follow-on patch removing all BUG_ON()
calls from these files, it's not acceptable to crash a user's box from a
driver that is handling parameters _you_ are feeding it.
thanks,
greg k-h
next prev parent reply other threads:[~2012-11-15 23:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 18:40 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-07 18:41 ` [PATCH 01/12] VMCI: context implementation George Zhang
2012-11-07 18:41 ` [PATCH 02/12] VMCI: datagram implementation George Zhang
2012-11-15 23:47 ` Greg KH [this message]
2012-11-07 18:41 ` [PATCH 03/12] VMCI: doorbell implementation George Zhang
2012-11-07 18:41 ` [PATCH 04/12] VMCI: device driver implementaton George Zhang
2012-11-07 18:41 ` [PATCH 05/12] VMCI: event handling implementation George Zhang
2012-11-07 18:42 ` [PATCH 06/12] VMCI: handle array implementation George Zhang
2012-11-07 18:42 ` [PATCH 07/12] VMCI: queue pairs implementation George Zhang
2012-11-15 23:48 ` Greg KH
2012-11-07 18:42 ` [PATCH 08/12] VMCI: resource object implementation George Zhang
2012-11-07 18:42 ` [PATCH 09/12] VMCI: routing implementation George Zhang
2012-11-07 18:42 ` [PATCH 10/12] VMCI: guest side driver implementation George Zhang
2012-11-07 18:42 ` [PATCH 11/12] VMCI: host " George Zhang
2012-11-16 0:03 ` Greg KH
2012-11-07 18:43 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2012-11-16 0:01 ` Greg KH
2012-11-27 0:03 ` Greg KH
2012-11-27 0:23 ` Dmitry Torokhov
2012-11-27 0:32 ` Greg KH
2012-11-27 0:45 ` [Pv-drivers] " Dmitry Torokhov
2012-11-30 16:47 ` Andy King
2012-11-30 17:09 ` Greg KH
2012-11-30 17:20 ` [Pv-drivers] " Dmitry Torokhov
2012-11-30 18:39 ` Greg KH
2012-11-30 18:45 ` Dmitry Torokhov
2012-11-30 18:57 ` Greg KH
2012-11-30 20:09 ` Dmitry Torokhov
2012-11-30 20:44 ` Greg KH
2012-11-30 20:58 ` Dmitry Torokhov
2012-11-30 21:17 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2013-01-08 23:52 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2013-01-08 23:53 ` [PATCH 02/12] VMCI: datagram implementation George Zhang
2012-11-21 20:31 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-21 20:32 ` [PATCH 02/12] VMCI: datagram implementation George Zhang
2012-11-01 17:28 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-11-01 17:28 ` [PATCH 02/12] VMCI: datagram implementation George Zhang
2012-10-30 1:03 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2012-10-30 1:03 ` [PATCH 02/12] VMCI: datagram implementation George Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115234714.GA8005@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=georgezhang@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).