Re: [PATCH v5 2/2] net: Add support for NTB virtual ethernet device

Greg KH
2012-11-16T01:26:33Z

On Thu, Nov 15, 2012 at 06:13:53PM -0700, Jon Mason wrote:
> On Thu, Nov 15, 2012 at 04:30:43PM -0800, Greg KH wrote:
> > On Mon, Nov 05, 2012 at 05:11:09PM -0700, Jon Mason wrote:
> > > A virtual ethernet device that uses the NTB transport API to
> > > send/receive data.
> > >
> > > Signed-off-by: Jon Mason <jon.mason@intel.com>
> > > Reviewed-by: Nicholas Bellinger <nab@linux-iscsi.org>
> > > ---
> > > MAINTAINERS | 1 +
> > > drivers/net/Kconfig | 4 +
> > > drivers/net/Makefile | 1 +
> > > drivers/net/ntb_netdev.c | 415 ++++++++++++++++++++++++++++++++++++++++++++++
> >
> > As I haven't taken the core yet, I can't take this. But even then, I
> > would need an ack from the network maintainers before I could.
>
> I have been Cc'ing netdev on these patches and gotten many good
> comments, but I can cc Dave Miller explicitly on my next version (as
> there will obviously need to be one based on your comments on the
> previous patch).

Don't cc: David, that's not the way to do it :)

> > And are you sure this is in the correct location in the tree?
>
> I assumed that the virtual network client that uses NTB as a transport
> would best fit in the network drivers. Is this a bad assumption?

No, but if you look, drivers/net/ has been cleaned up a bunch, so
perhaps a subdirectory under there is best. I'll leave that up to the
netdev developers to discuss.

thanks,

greg k-h