From: Greg KH <gregkh@linuxfoundation.org>
To: Jon Mason <jon.mason@intel.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-pci@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>,
Nicholas Bellinger <nab@linux-iscsi.org>
Subject: Re: [PATCH v5 1/2] PCI-Express Non-Transparent Bridge Support
Date: Thu, 15 Nov 2012 17:18:41 -0800 [thread overview]
Message-ID: <20121116011841.GB32285@kroah.com> (raw)
In-Reply-To: <20121116010621.GI24723@jonmason-lab>
On Thu, Nov 15, 2012 at 06:06:21PM -0700, Jon Mason wrote:
> > > +static inline unsigned int ntb_query_max_cbs(struct ntb_device *ndev)
> > > +{
> > > + return ndev->max_cbs;
> > > +}
> >
> > It is shorter, and simpler, to just write the '->variable' version out
> > for this, than to make the function call here. Why are these needed?
> > Especially when I see the driver code not using them. Please remove.
>
> This is used in ntb_transport.c. It is used to show how many
> interrupts, and there-by clients, the transport layer can have. I can
> make it a macro and/or put it in a header file, if that suits you
> better.
No, just reference the field of the structure directly, no need for a
function or a macro.
thanks,
greg k-h
next prev parent reply other threads:[~2012-11-16 1:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 0:11 [PATCH v5 0/2] PCI-Express Non-Transparent Bridge Support Jon Mason
2012-11-06 0:11 ` [PATCH v5 1/2] " Jon Mason
2012-11-16 0:29 ` Greg KH
2012-11-16 1:06 ` Jon Mason
2012-11-16 1:18 ` Greg KH [this message]
2012-11-16 0:29 ` Greg KH
2012-11-06 0:11 ` [PATCH v5 2/2] net: Add support for NTB virtual ethernet device Jon Mason
2012-11-16 0:30 ` Greg KH
2012-11-16 1:13 ` Jon Mason
2012-11-16 1:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116011841.GB32285@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dave.jiang@intel.com \
--cc=jon.mason@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox