Re: [PATCH] serial: ifx6x60: Add module parameters to manage the modem status through sysfs

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

On Fri, 16 Nov 2012 04:38:06 -0800
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Fri, Nov 16, 2012 at 07:59:49AM -0500, Jun Chen wrote:
> > 
> > The Medfield Platform implements a recovery procedure consisting in an escalation
> > from simple and light recovery procedures to stronger ones with increased visibility
> > and impact to end-user.After platform find some problem from Modem,such as no response,
> > platform will try do modem warm reset.If several tries failed, platform will try to
> > do modem cold boot procedure.For Modem Cold Boot, AP is responsible to generate
> > blob (binary object containing PIN code and other necessary information).
> > Blob is stored in AP volatile memory. AP decides to read PIN code from cache instead of
> > prompting end-user, and sends it to modem as if end-user had entered it.
> > 
> > This patch add module parameters to manage the modem status through sysfs.
> > Reset_modem can be read and write by user space.When read the reset_modem,user space will
> > get the mdm_reset_state which used to avoid to run twice at once.When set the reset_modem to
> > IFX_COLD_RESET_REQ,modem will do cold reset, other val value will trigger modem reset.
> > 
> > Hangup_reasons used to give one interface to user space to know and clear the modem reset reasons.
> > Now there are four reasons:SPI timeout, modem initiative reset,modem coredump,spi tranfer error.
> 
> Why are these module parameters?  Why not just "real" sysfs files
> instead?  That way, if you have multiple devices in a system, it will
> work properly for them.  Right now you are limited to 1 device, right?

Yes and its highly unlikely that there will ever be anyone who needs two.

Alan