From: Greg KH <gregkh@linuxfoundation.org>
To: Johan Meiring <johanmeiring@gmail.com>
Cc: pe1dnn@amsat.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: wlags49_h2: ap_h2: fixes coding style issues
Date: Fri, 16 Nov 2012 09:05:37 -0800 [thread overview]
Message-ID: <20121116170537.GA30626@kroah.com> (raw)
In-Reply-To: <1353084759-8792-1-git-send-email-johanmeiring@gmail.com>
On Fri, Nov 16, 2012 at 06:52:39PM +0200, Johan Meiring wrote:
> This corrects several instances of spaces before tabs and incorrect spacing around "*" characters. It also fixes some 80+ character line length issues, but the majority of such cases have been left as is, as this was probably the author's intention.
Please wrap your changelog lines at the properly length (i.e. 72
columns)
Also, please only do one thing per patch. You are doing multiple things
here, which makes it hard to review.
Same goes for the other patches in this series, please break it up into
smaller steps, which makes for more patches, but it makes it easier to
review to ensure you didn't do something wrong.
Care to redo this and resend it?
thanks,
greg k-h
next prev parent reply other threads:[~2012-11-16 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 16:52 [PATCH 1/3] staging: wlags49_h2: ap_h2: fixes coding style issues Johan Meiring
2012-11-16 17:05 ` Greg KH [this message]
2012-11-16 17:07 ` Johan Meiring
2012-11-19 7:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116170537.GA30626@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=johanmeiring@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pe1dnn@amsat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).