From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Christoph Lameter <cl@linux.com>
Cc: Shan Wei <shanwei88@gmail.com>,
dipankar@in.ibm.com,
Kernel-Maillist <linux-kernel@vger.kernel.org>,
Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH v3 6/9] rcu: use __this_cpu_read helper instead of per_cpu_ptr(p, raw_smp_processor_id())
Date: Fri, 16 Nov 2012 10:09:56 -0800 [thread overview]
Message-ID: <20121116180956.GE3270@linux.vnet.ibm.com> (raw)
In-Reply-To: <0000013b0a505095-87cdf6aa-4e22-4439-9fe2-5c93044077ff-000000@email.amazonses.com>
On Fri, Nov 16, 2012 at 05:42:14PM +0000, Christoph Lameter wrote:
>
> On Fri, 16 Nov 2012, Paul E. McKenney wrote:
>
> > If you either show me some significant performance benefits or get me
> > an independent Tested-by, in both cases on a range of hardware (e.g.,
> > x86 on the one hand and ARM or Power on the other), then I will queue it.
>
> Just putting the code generated for x86 before and after side
> by side would be enough to convince you I think.
If accompanied by similar before/after code for ARM or Power, sure.
Thanx, Paul
> > I wasn't prioritizing this one very high because it does not appear
> > to be on any sort of fastpath. If I am wrong about that, then you
> > have a good performance-benefit case, right? ;-)
>
> I do not think this needs to be a priority item. Just stick it in the tree
> somewhere to merge for the next merge period.
>
next prev parent reply other threads:[~2012-11-16 18:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 1:52 [PATCH v3 6/9] rcu: use __this_cpu_read helper instead of per_cpu_ptr(p, raw_smp_processor_id()) Shan Wei
2012-11-16 8:32 ` Shan Wei
2012-11-16 16:43 ` Paul E. McKenney
2012-11-16 17:42 ` Christoph Lameter
2012-11-16 18:09 ` Paul E. McKenney [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-11-09 2:21 Shan Wei
2012-11-09 20:14 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116180956.GE3270@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=cl@linux.com \
--cc=dipankar@in.ibm.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shanwei88@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox