From: Oleg Nesterov <oleg@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Jovi Zhang" <bookjovi@gmail.com>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Srikar Dronamraju" <srikar@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] uprobe: fix misleading log entry
Date: Mon, 19 Nov 2012 13:32:21 +0100 [thread overview]
Message-ID: <20121119123221.GA31544@redhat.com> (raw)
In-Reply-To: <1353321774.6276.4.camel@gandalf.local.home>
On 11/19, Steven Rostedt wrote:
>
> On Thu, 2012-10-25 at 16:12 +0200, Oleg Nesterov wrote:
> > On 07/18, Jovi Zhang wrote:
> > >
> > > --- a/kernel/trace/trace_uprobe.c
> > > +++ b/kernel/trace/trace_uprobe.c
> > > @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv)
> > > if (argv[0][0] == '-')
> > > is_delete = true;
> > > else if (argv[0][0] != 'p') {
> > > - pr_info("Probe definition must be started with 'p', 'r' or" " '-'.\n");
> > > + pr_info("Probe definition must be started with 'p' or '-'.\n");
> > > return -EINVAL;
> > > }
> >
> > Thanks, applied as 0d13ac96 (with Srikar's ack) in misc#uprobes/core
> >
> > Oleg.
>
> Hmm, this doesn't look like it ever got applied to mainline. Was it
> dropped?
I didn't send the pull request yet, will do today.
Oleg.
prev parent reply other threads:[~2012-11-19 12:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 3:08 [PATCH] uprobe: fix misleading log entry Jovi Zhang
2012-07-18 9:22 ` Srikar Dronamraju
2012-07-18 11:43 ` Jovi Zhang
2012-07-18 15:24 ` Anton Arapov
2012-10-12 0:06 ` Jovi Zhang
2012-10-12 4:50 ` Srikar Dronamraju
2012-10-25 14:12 ` Oleg Nesterov
2012-11-19 10:42 ` Steven Rostedt
2012-11-19 12:32 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119123221.GA31544@redhat.com \
--to=oleg@redhat.com \
--cc=bookjovi@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).