From: "Serge E. Hallyn" <serge@hallyn.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
Gao feng <gaofeng@cn.fujitsu.com>,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] pidns: remove the useless function is_container_init
Date: Mon, 19 Nov 2012 14:33:07 +0000 [thread overview]
Message-ID: <20121119143307.GA4620@mail.hallyn.com> (raw)
In-Reply-To: <87obitad1v.fsf@xmission.com>
Quoting Eric W. Biederman (ebiederm@xmission.com):
> "Serge E. Hallyn" <serge@hallyn.com> writes:
>
> > Quoting Gao feng (gaofeng@cn.fujitsu.com):
> >> since commit 1cdcbec1a3372c0c49c59d292e708fd07b509f18,
> >> is_container_init has no used for a long time.
> >>
> >> just remove it.
> >
> > Only thing is it's being exported, so I think it needs to go through
> > deprecation.
>
> Exports do not create an ABI. No internal kernel users are enough.
Ok. I personally don't know of any out of tree users anyway, just seemed
like a warning for one cycle would be friendly :)
Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
thanks,
-serge
prev parent reply other threads:[~2012-11-19 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 10:44 [PATCH] pidns: remove the useless function is_container_init Gao feng
2012-11-19 14:12 ` Serge E. Hallyn
2012-11-19 14:21 ` Eric W. Biederman
2012-11-19 14:33 ` Serge E. Hallyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119143307.GA4620@mail.hallyn.com \
--to=serge@hallyn.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox