From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Davide Ciminaghi <ciminaghi@gnudd.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: introduce tables for readable/writeable/volatile/precious checks
Date: Tue, 20 Nov 2012 15:05:11 +0900 [thread overview]
Message-ID: <20121120060509.GB10560@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1353331913-24941-1-git-send-email-ciminaghi@gnudd.com>
[-- Attachment #1: Type: text/plain, Size: 796 bytes --]
On Mon, Nov 19, 2012 at 02:31:53PM +0100, Davide Ciminaghi wrote:
> Many of the regmap enabled drivers implementing one or more of the
> readable, writeable, volatile and precious methods use the same code
> pattern:
>
> return ((reg >= X && reg <= Y) || (reg >= W && reg <= Z) || ...)
>
> Switch to a data driven approach, using tables to describe
> readable/writeable/volatile and precious registers ranges instead.
> The table based check can still be overridden by passing the usual function
> pointers via struct regmap_config.
Sorry, the code looks good but I just realised we already have a feature
called ranges - the paged window support also calls the regions it uses
ranges. Can I suggest access_table or similar instead? Sorry about
that - I should've realised.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-20 6:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 13:31 [PATCH] regmap: introduce tables for readable/writeable/volatile/precious checks Davide Ciminaghi
2012-11-20 6:05 ` Mark Brown [this message]
2012-11-20 8:41 ` Davide Ciminaghi
-- strict thread matches above, loose matches on Subject: below --
2012-11-20 14:20 Davide Ciminaghi
2012-11-21 2:11 ` Mark Brown
2012-10-25 12:24 ciminaghi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120060509.GB10560@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ciminaghi@gnudd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox