Re: DVS regulator drivers

Mark Brown
2012-11-20T08:28:02Z

[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]

On Tue, Nov 20, 2012 at 09:17:46AM +0100, Guennadi Liakhovetski wrote:
> On Tue, 20 Nov 2012, Mark Brown wrote:

> > Please don't invent terminology or repurpose existing terminology like
> > this, it's just confusing - obvious essentially all regulators covered
> > by the regulator API support voltage scaling which is the usual meaning
> > of DVS.

> Right, sorry, a more precise term would be a "pin-selectable DVS," right?

Yup.

> > Can you be more specific about your concern here? The above code does
> > exactly what the comment says, it will set the selector it just picked.

> Your patch fixes exactly the problem, that I was pointing at, thanks.

Oh, right. It sounded like you also had some concern with on_vsel which
I couldn't figure out.

> > You did spot one bug (I think due to bitrot) which I just fixed but in
> > general I've just TLDRed this as it's a bit unclear what you're trying
> > to say here, can you be a bit more concise here? I'm not sure if
> > there's a general point or if it's specific code issues?

> Sorry, let's try again. Just to bring back the "too long and a bit unclear
> part:"

It was the mail as a whole - I spent less time on lp872x since I don't
have any access to the hardware either.

> where dvs is platform data, i.e., all parameters are constant. So,
> lp872x_set_dvs() never switches anything, and in fact it could just have
> been called just once from initialisation to set the GPIO. This also
> means, that only one context - either SEL_V1 or SEL_V2 is used.

I think you're right there.