Re: [PATCH 2/9] ext4: honor the O_SYNC flag for aysnchronous direct I/O requests

Jeff Moyer
2012-11-21T14:09:59Z

Jan Kara <jack@suse.cz> writes:

>> Just to be clear, are you saying you would like me to remove the
>> mutex_lock/unlock pair from ext4_sync_file? (I had already factored out
>> the common code between this new code path and the fsync path in my tree.)
> Yes, after some thinking I came to that conclusion. We actually need to
> keep i_mutex around ext4_flush_unwritten_io() to avoid livelocks but the
> rest doesn't need it. The change should be definitely a separate patch just
> in case there's something subtle I missed and we need to bisect in
> future... I've attached a patch for that so that blame for bugs goes my way
> ;) Compile tested only so far. I'll give it some more testing overnight.

Great, thanks Jan! I'll include this in the next posting.

Cheers,
Jeff