[PATCH 1/5] balancenuma: fix typo in handling pmd numa fault

[PATCH 1/5] balancenuma: fix typo in handling pmd numa fault

[Hillf Danton]

s/ptep/pmdp/

Also a cleanup packed: use haddr directly.

Btw, will spin if you no longer need the debug trap.

Signed-off-by: Hillf Danton <dhillf@gmail.com>
---

--- a/mm/huge_memory.c	Sat Nov 17 11:37:36 2012
+++ b/mm/huge_memory.c	Sat Nov 17 11:54:18 2012
@@ -1055,9 +1055,9 @@ clear_pmdnuma:
 		goto out_unlock;

 	pmd = pmd_mknonnuma(pmd);
-	set_pmd_at(mm, addr & HPAGE_PMD_MASK, pmdp, pmd);
+	set_pmd_at(mm, haddr, pmdp, pmd);
 	VM_BUG_ON(pmd_numa(*pmdp));
-	update_mmu_cache_pmd(vma, addr, ptep);
+	update_mmu_cache_pmd(vma, addr, pmdp);

 out_unlock:
 	spin_unlock(&mm->page_table_lock);
--

Re: [PATCH 1/5] balancenuma: fix typo in handling pmd numa fault

[Mel Gorman]

On Sat, Nov 17, 2012 at 01:08:35PM +0800, Hillf Danton wrote:
> s/ptep/pmdp/
> 
> Also a cleanup packed: use haddr directly.
> 
> Btw, will spin if you no longer need the debug trap.
> 

Thanks Hillf. I pulled in 1-3 and patch 5 from this. I left patch 4 for
now as the way it's laid out means it needs to check for the max weight.
It's sortof recovered later by checking if selected_nid != this_nid but
it's doing more work than necessary. I'll re-examine this again but
ideally this particular section would be replaced by something smarter.

-- 
Mel Gorman
SUSE Labs