Re: [PATCH v4] checkpatch: debugfs_remove() can take NULL

Andy Whitcroft
2012-11-20T14:47:52Z

On Tue, Nov 20, 2012 at 06:43:49AM -0800, Joe Perches wrote:
> On Tue, 2012-11-20 at 14:29 +0000, Andy Whitcroft wrote:
>
> > This all looks sensible, though we still have three blocks doing the
> > same thing. How about we standardise this check into a single check,
> > generating the capacity from the matched name.
> []
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > + if ($line =~ /\b(kfree|usb_free_urb|debugfs_remove(?:_recursive)?)$expr/) {
> > + my $func = $1;
> > + my $func_capacity = "NEEDLESS_$1";
> > +
> > + $func_capacity =~ s/(.$)/\U$1\E/;
> > +
> > + WARN($func_capacity,
> > + "$func(NULL) is safe this check is probably not required\n" . $hereprev);
>
> Perhaps just
> WARN("NEEDLESS_IF",

I would cirtainly be happy with that, I was trying to avoid changing the
capacity for the existing NEEDLESS_KFREE. If compatibility there isn't
an issue then that makes life even simpler.

-apw