Re: [PATCH] checkpatch: consolidate if (foo) bar(foo) checks and add debugfs_remove

Joe Perches
2012-11-20T15:51:19Z

On Tue, 2012-11-20 at 15:37 +0000, Andy Whitcroft wrote:
> Consolidate the if (foo) bar(foo) detectors into a single check. Add
> debugfs_remove and family.
>
> Based on a patch by Constantine Shulyupin <const@MakeLinux.com>.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
>
> +# check for needless "if (<foo>) fn(<foo>)" uses
> + if ($prevline =~ /\bif\s*\(\s*($Lval)\s*\)/) {
> + my $expr = '\s*\(\s*' . quotemeta($1) . '\s*\)\s*;';
> +
[]
> +# check for needless debugfs_remove() and debugfs_remove_recursive*() checks

Hey Andy, that's an incomplete comment.
Just remove it.

> + if ($line =~ /\b(kfree|usb_free_urb|debugfs_remove(?:_recursive)?)$expr/) {
> + WARN('NEEDLESS_IF',
> + "$1(NULL) is safe this check is probably not required\n" . $hereprev);
> }
> }
>