From: Andy Whitcroft <apw@canonical.com>
To: Constantine Shulyupin <const@makelinux.com>
Cc: Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH v4] checkpatch: debugfs_remove() can take NULL
Date: Tue, 20 Nov 2012 15:22:27 +0000 [thread overview]
Message-ID: <20121120152227.GI7955@dm> (raw)
In-Reply-To: <CAE7jHC-QqYCvSVR2JwCQjrSx6yH0-41GXfid6FSPP3xB8FV=2w@mail.gmail.com>
On Tue, Nov 20, 2012 at 05:10:43PM +0200, Constantine Shulyupin wrote:
> On Tue, Nov 20, 2012 at 4:58 PM, Joe Perches <joe@perches.com> wrote:
> > I don't think it's an issue. I'm not sure anyone
> > really uses --ignore for much other than LONG_LINE.
>
> Indeed. Must all code be 80 characters width? My be my be better to
> make line length configurable than ignore it? Or at least print actual
> line length to allow developer be aware how long lines is.
> I think 90 char line is preferable than wrapped two or even three times line.
If wrapping there is that much better then wrapping there is appropriate
in some cases. The currently limit has been revisited a bunch of times,
and in none have we agreed on what to change it to. It therefore
remains the recommendation.
-apw
next prev parent reply other threads:[~2012-11-20 15:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 22:20 [PATCH v4] checkpatch: debugfs_remove() can take NULL Constantine Shulyupin
2012-11-20 14:29 ` Andy Whitcroft
2012-11-20 14:43 ` Joe Perches
2012-11-20 14:47 ` Andy Whitcroft
2012-11-20 14:50 ` Constantine Shulyupin
2012-11-20 14:58 ` Joe Perches
2012-11-20 15:10 ` Constantine Shulyupin
2012-11-20 15:22 ` Andy Whitcroft [this message]
2012-11-20 20:57 ` [PATCH] checkpatch: Allow control over line length warning, default remains 80 Joe Perches
2012-11-20 15:37 ` [PATCH] checkpatch: consolidate if (foo) bar(foo) checks and add debugfs_remove Andy Whitcroft
2012-11-20 15:51 ` Joe Perches
2012-11-20 16:39 ` Andy Whitcroft
2012-11-20 18:37 ` Joe Perches
2012-11-20 19:17 ` [PATCH V2] " Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120152227.GI7955@dm \
--to=apw@canonical.com \
--cc=const@makelinux.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox