From: Solomon Peachy <pizza@shaftnet.org>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] [firmware_class] Fix compile with no builtin firmware
Date: Wed, 21 Nov 2012 09:01:10 -0500 [thread overview]
Message-ID: <20121121140109.GA7549@shaftnet.org> (raw)
In-Reply-To: <20121121093528.4fe11c26@tom-ThinkPad-T410>
[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]
On Wed, Nov 21, 2012 at 09:35:28AM +0800, Ming Lei wrote:
> Solomon, I can't duplicate the build failure with your .config on 3.7-rc5-next.
Okay, so it's since been fixed.
> > * The #ifdef wraps code that pertains solely to built-in firmware, (ie
> > CONFIG_FIRMWARE_IN_KERNEL) and has an #else path for when it's disabled.
> > * There is no point in a CONFIG_FW_LOADER test inside firmware_class.c
> > when the file isn't even compiled unless CONFIG_FW_LOADER is defined.
>
> Enabling CONFIG_EXTRA_FIRMWARE still can make one firmware built in kernel
> even though CONFIG_FIRMWARE_IN_KERNEL isn't defined, so your patch will break
> this case.
So... isn't the logical solution here to make CONFIG_EXTRA_FIRMARE
depend on (or enable) CONFIG_FIRMWARE_IN_KERNEL? After all, the two are
apparently related.
I can update my patch to include this, and rewrite the commit message so
it's relevant to modern kernels, or I can just drop this and forget the
whole affair.
- Solomon
--
Solomon Peachy pizza at shaftnet dot org
Melbourne, FL ^^ (mail/jabber/gtalk) ^^
Quidquid latine dictum sit, altum viditur.
[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2012-11-21 14:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 14:45 [PATCH] [firmware_class] Fix compile with no builtin firmware Solomon Peachy
2012-11-20 16:01 ` Ming Lei
2012-11-20 16:10 ` Solomon Peachy
2012-11-20 16:33 ` Greg KH
2012-11-20 18:12 ` Solomon Peachy
2012-11-21 1:35 ` Ming Lei
2012-11-21 14:01 ` Solomon Peachy [this message]
2012-11-22 1:45 ` Ming Lei
2012-11-22 2:15 ` Solomon Peachy
2012-11-22 2:42 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121140109.GA7549@shaftnet.org \
--to=pizza@shaftnet.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox