From: Samuel Ortiz <sameo@linux.intel.com>
To: Inderpal Singh <inderpal.singh@linaro.org>,
Sangbeom Kim <sbkim73@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
patches@linaro.org
Subject: Re: [PATCH] MFD: SEC: Fix reg_offset for interrupt registers
Date: Wed, 21 Nov 2012 17:52:58 +0100 [thread overview]
Message-ID: <20121121165258.GD18738@sortiz-mobl> (raw)
In-Reply-To: <1350454735-17697-1-git-send-email-inderpal.singh@linaro.org>
Hi Inderpal,
On Wed, Oct 17, 2012 at 11:48:55AM +0530, Inderpal Singh wrote:
> reg_offset is offset of the status/mask registers. Now, since status_base
> and mask_base are pointing to corresponding first registers, reg_offset
> should start from 0 otheriwse regmap_add_irq_chip will fail during probe.
>
> Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
> ---
> It is based on Samuel's for-next-merge branch of mfd-2.6 tree.
>
> drivers/mfd/sec-irq.c | 102 ++++++++++++++++++++++++-------------------------
> 1 file changed, 51 insertions(+), 51 deletions(-)
I queued this one to my for-linus branch since it basically prevents IRQs from
working here. But it seems weird that such a mistake was not caught earlier.
So I'd like to get Sangbeom's ACK before pushing this one upstream.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2012-11-21 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 6:18 [PATCH] MFD: SEC: Fix reg_offset for interrupt registers Inderpal Singh
2012-11-21 16:52 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121165258.GD18738@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=inderpal.singh@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox