From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: add an AS3711 PMIC MFD driver
Date: Thu, 22 Nov 2012 10:18:37 +0900 [thread overview]
Message-ID: <20121122011835.GD4371@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1211211916160.842@axis700.grange>
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
On Wed, Nov 21, 2012 at 07:21:02PM +0100, Guennadi Liakhovetski wrote:
> + regmap_read(as3711->regmap, AS3711_ASIC_ID_1, &id1);
> + regmap_read(as3711->regmap, AS3711_ASIC_ID_2, &id2);
> + dev_info(as3711->dev, "AS3711 detected: %x:%x\n", id1, id2);
> + if (id1 != 0x8b)
> + return -ENODEV;
This looks odd - you're printing the "AS3711 detected" message prior to
checking the device ID which will be a bit confusing if there's a
problem. Should probably do this after the ID check (and ideally also
check the return value of regmap_read(), it's especially important
during device identification where someone might've typoed the address).
Otherwise this looks good.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-11-22 19:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 18:21 [PATCH 1/2] mfd: add an AS3711 PMIC MFD driver Guennadi Liakhovetski
2012-11-21 18:21 ` [PATCH 2/2] regulator: add a regulator driver for the AS3711 PMIC Guennadi Liakhovetski
2012-11-22 1:27 ` Mark Brown
2012-11-22 1:18 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121122011835.GD4371@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox