From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758876Ab2KWCFX (ORCPT ); Thu, 22 Nov 2012 21:05:23 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:45594 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756294Ab2KWCFW (ORCPT ); Thu, 22 Nov 2012 21:05:22 -0500 Date: Fri, 23 Nov 2012 11:05:18 +0900 From: Mark Brown To: Lothar =?iso-8859-1?Q?Wa=DFmann?= Cc: alsa-devel@alsa-project.org, Shawn Guo , linux-kernel@vger.kernel.org Subject: Re: [BUGFIX PATCH] ASoC: fsl: fix miscompilation of snd-soc-imx-pcm Message-ID: <20121123020517.GJ4385@opensource.wolfsonmicro.com> References: <1353587470-11994-1-git-send-email-LW@KARO-electronics.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Y+Z5jE7Arku/2GrR" Content-Disposition: inline In-Reply-To: <1353587470-11994-1-git-send-email-LW@KARO-electronics.de> X-Cookie: Don't read everything you believe. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Y+Z5jE7Arku/2GrR Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 22, 2012 at 01:31:06PM +0100, Lothar Wa=DFmann wrote: > obj-$(CONFIG_SND_SOC_IMX_PCM) +=3D snd-soc-imx-pcm.o > snd-soc-imx-pcm-y :=3D imx-pcm.o > -snd-soc-imx-pcm-$(CONFIG_SND_SOC_IMX_PCM_FIQ) +=3D imx-pcm-fiq.o > -snd-soc-imx-pcm-$(CONFIG_SND_SOC_IMX_PCM_DMA) +=3D imx-pcm-dma.o > +ifneq ($(CONFIG_SND_SOC_IMX_PCM_FIQ),) > + snd-soc-imx-pcm-objs +=3D imx-pcm-fiq.o > +endif > +ifneq ($(CONFIG_SND_SOC_IMX_PCM_DMA),) > + snd-soc-imx-pcm-objs +=3D imx-pcm-dma.o > +endif What is the actual bug here? This fix doesn't look obviously right, and if we do need to move to -objs for some reason then the block ought to be in the -objs section of the Makefile. --Y+Z5jE7Arku/2GrR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJQrtnJAAoJELSic+t+oim9oN4QAJThJQxMGp5w28hEwKUk2cv1 xqHdFlKhz3b405mhKnknSbniWISsZTsodwW5U84xtcYA7x6aD0jneXeleV/UaIPS vOQbQe7Modz3fu5k4/F5lIdg5jG9imYixZJ52+qyqpcG+H1fFMQdwFF1s2d4cCwi NSgj3D+ki3dxQrMzPK9NOuhVD0Q+Hy4Uc4m/6PsrehnI6zT9zdz1WWX+jYUgOLxm gl4HsfgaYTGwMGNYOHFHwie4xrkofYWsKjLqalmTH1h7u9XxwGken4N1mI8oQVWi Mn4YQia3ZWPYm5kbK4nlpdOguAeOEtRGfEO3+64waFIm+4SwZICyUYmIst82zQKW cBT2dsQGPh6to+/ycXRiGZFiaazvscANtV6XW+CDdEChU3D8xlTgQhQbGMHDRE9o T3vTLRLqCMScHN9vosR9Xv5a1BiRCTZXG1u0EWIXGjJHu153IN7SGUUKsEM7oozm axvRWvCiJr0CVw4GLBhVyvLy3zLSz3U7udLYeLgKvtxZgowb+9rI28ZIM32xtXWe Tmz+/2y0J6TBxduiefxgKuQc1UA8+6LOKebHBu9MXX75sSObksaGxRO/P4XGuyQK zM4WRRWeJ+Isip3C0f1Kj7fLMuLIHN11gOEVcXJ6klGWzwSp1ggZBmEv5Uc4Vn4c Cr8Ny8dyT5JdcD+thQ7l =6z2r -----END PGP SIGNATURE----- --Y+Z5jE7Arku/2GrR--